Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 1462463004: Remove unused declarations - skip summaries and completion. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unused declarations - skip summaries and completion. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b46dd600d0b7474a014488bc9c1d2cf20eca2ffe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 3 chunks +6 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/linter/linter.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 7 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 1 month ago (2015-11-18 22:07:08 UTC) #1
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-18 23:01:02 UTC) #2
scheglov
5 years, 1 month ago (2015-11-18 23:21:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b46dd600d0b7474a014488bc9c1d2cf20eca2ffe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698