Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1462443003: EnsureOpenSSLInit before calling into WebRTC. (Closed)

Created:
5 years, 1 month ago by davidben
Modified:
5 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

EnsureOpenSSLInit before calling into WebRTC. BoringSSL may currently only be initialized by one piece of code, so full initialization must happen in Chromium code, rather than WebRTC. Historically, this was because the locking callbacks needed to be configured. This is gone, but EnsureOpenSSLInit still configures NEON support on Android and detects a CPU with known broken NEON support. Until that's moved to inside the library (https://crbug.com/542879), Chromium must initialize some of the stack ourselves. BUG=556462 Committed: https://crrev.com/f044335430bdadadc8c31653a38551eda48994c6 Cr-Commit-Position: refs/heads/master@{#360466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
davidben
5 years, 1 month ago (2015-11-18 22:40:32 UTC) #2
guoweis_webrtc
lgtm This seems to address the broken neon case as crbug.com/341598. I would assume standalone ...
5 years, 1 month ago (2015-11-18 23:20:40 UTC) #4
davidben
On 2015/11/18 23:20:40, guoweis wrote: > lgtm > > This seems to address the broken ...
5 years, 1 month ago (2015-11-19 00:08:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462443003/1
5 years, 1 month ago (2015-11-19 00:12:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 01:44:42 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 01:45:29 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f044335430bdadadc8c31653a38551eda48994c6
Cr-Commit-Position: refs/heads/master@{#360466}

Powered by Google App Engine
This is Rietveld 408576698