Mark base::Tuple as final

Mark base::Tuple as final

Extending tuple confuses the compiler when we replace
base::Tuple with std::tuple.
This CL removes a base::Tuple extension and forbids it.

BUG=554987
Committed: https://crrev.com/904f19454a71c733205d9e68bc8faa93a6fdce3e
Cr-Commit-Position: refs/heads/master@{#360404}

[tzik, 2015-11-18 03:53:06]

Description was changed from

==========
Mark base::Tuple as final

BUG=
==========

to

==========
Mark base::Tuple as final

Extending tuple confuses the compiler when we replace
base::Tuple with std::tuple.
This CL removes a base::Tuple extension and forbid further
case.

BUG=554987
==========

[tzik, 2015-11-18 03:53:06]

tzik@chromium.org changed reviewers:
+ thakis@chromium.org, vitalybuka@chromium.org

[tzik, 2015-11-18 03:53:11]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-18 03:53:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1462443002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1462443002/1

[commit-bot: I haz the power, 2015-11-18 05:23:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 05:23:37]

Dry run: This issue passed the CQ dry run.

[tzik, 2015-11-18 06:22:33]

Description was changed from

==========
Mark base::Tuple as final

Extending tuple confuses the compiler when we replace
base::Tuple with std::tuple.
This CL removes a base::Tuple extension and forbid further
case.

BUG=554987
==========

to

==========
Mark base::Tuple as final

Extending tuple confuses the compiler when we replace
base::Tuple with std::tuple.
This CL removes a base::Tuple extension and forbids it.

BUG=554987
==========

[tzik, 2015-11-18 06:22:45]

PTAL

[Nico, 2015-11-18 06:25:56]

lgtm

I guess this is to work around the msvc2013 crash in your other CL – did you
file an msconnect bug for that? (Or, alternatively, did you check if that's
fixed in 2015?)

[tzik, 2015-11-18 08:03:48]

On 2015/11/18 06:25:56, Nico wrote:
> lgtm
> 
> I guess this is to work around the msvc2013 crash in your other CL – did
you
> file an msconnect bug for that? (Or, alternatively, did you check if that's
> fixed in 2015?)

This is for clang + libc++ build, rather than MSVC 2013. (Updated the issue.)

[Vitaly Buka (NO REVIEWS), 2015-11-18 20:10:00]

lgtm

[Nico, 2015-11-18 20:26:06]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-11-18 20:27:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1462443002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1462443002/1

[commit-bot: I haz the power, 2015-11-18 20:35:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-18 20:36:41]

Patchset 1 (id:??) landed as
https://crrev.com/904f19454a71c733205d9e68bc8faa93a6fdce3e
Cr-Commit-Position: refs/heads/master@{#360404}