Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 1462433002: Remove deprecated code path from analyzer.py. (Closed)

Created:
5 years, 1 month ago by Dirk Pranke
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
gyp-developer_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -492 lines) Patch
M pylib/gyp/generator/analyzer.py View 5 chunks +3 lines, -106 lines 0 comments Download
D test/analyzer/gyptest-analyzer-deprecated.py View 1 chunk +0 lines, -386 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Dirk Pranke
5 years, 1 month ago (2015-11-18 02:39:50 UTC) #1
sky
LGTM
5 years, 1 month ago (2015-11-18 16:17:42 UTC) #3
Dirk Pranke
5 years, 1 month ago (2015-11-19 02:10:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f06a5a0e46ce3a1d3a51fbd7fa8df5c72f47d881 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698