Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 1462423002: In dashboard/dispatcher.py, create the WSGIApplication with debug=False. (Closed)

Created:
5 years, 1 month ago by qyearsley
Modified:
5 years, 1 month ago
Reviewers:
sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

In dashboard/dispatcher.py, create the WSGIApplication with debug=False. In https://cloud.google.com/appengine/docs/python/tools/webapp/wsgiapplicationclass, it suggests always using debug=False; the difference is that when an exception is raised, in non-debug mode, it will still be logged, but an opaque "500 error" message is shown to the user instead of a call stack. Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/5e75c60da6e5a86a312519f5a20016159ec45012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -56 lines) Patch
M dashboard/dashboard/dispatcher.py View 2 chunks +58 lines, -56 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
qyearsley
5 years, 1 month ago (2015-11-20 19:29:14 UTC) #2
sullivan
lgtm
5 years, 1 month ago (2015-11-20 19:51:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462423002/1
5 years, 1 month ago (2015-11-20 21:16:33 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 21:24:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698