GN: Manually search path for Python

tools/gn/setup.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/setup.h"
 
 #include <stdlib.h>
 
 #include <algorithm>
 #include <sstream>
@@ skipping 130 matching lines @@
                          scoped_ptr<Item> item) {
   DCHECK(item);
   main_loop->PostTask(FROM_HERE, base::Bind(&Builder::ItemDefined, builder,
                                             base::Passed(&item)));
 }
 
 void DecrementWorkCount() {
   g_scheduler->DecrementWorkCount();
 }
 
+#if defined(OS_WIN)
+base::FilePath FindWindowsPython() {
+  const base::char16 kPythonExeName[] = L"python.exe";

[scottmg, 2015/11/21 00:23:34]

Could hoist this out so that the failure case can also use it.

+  base::char16 current_directory[MAX_PATH];
+  ::GetCurrentDirectory(MAX_PATH, current_directory);
+
+  // First search for python.exe in the current directory.
+  base::FilePath cur_dir_candidate_exe =
+      base::FilePath(current_directory).Append(kPythonExeName);
+  if (base::PathExists(cur_dir_candidate_exe))
+    return cur_dir_candidate_exe;
+
+  // Get the path.
+  const base::char16 kPathEnvVarName[] = L"Path";
+  DWORD path_length = ::GetEnvironmentVariable(kPathEnvVarName, NULL, 0);

[scottmg, 2015/11/21 00:23:34]

nullptr

+  if (path_length == 0)
+    return base::FilePath();
+  scoped_ptr<base::char16[]> full_path(new base::char16[path_length]);
+  ::GetEnvironmentVariable(kPathEnvVarName, full_path.get(), path_length);

[scottmg, 2015/11/21 00:23:34]

DCHECK return value == path_length - 1 maybe.

+
+  // Search for python.exe in the path.
+  for (const auto& component : base::SplitStringPiece(
+           base::StringPiece16(full_path.get(), path_length), L";",
+           base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY)) {
+    base::FilePath candidate_exe =
+        base::FilePath(component).Append(kPythonExeName);
+    if (base::PathExists(candidate_exe))
+      return candidate_exe;
+  }
+  return base::FilePath();
+}
+#endif
+
 }  // namespace
 
 const char Setup::kBuildArgFileName[] = "args.gn";
 
 Setup::Setup()
     : build_settings_(),
       loader_(new LoaderImpl(&build_settings_)),
       builder_(new Builder(loader_.get())),
       root_build_file_("//BUILD.gn"),
       check_public_headers_(false),
@@ skipping 310 matching lines @@
   }
 
   build_settings_.SetBuildDir(resolved);
   return true;
 }
 
 void Setup::FillPythonPath() {
   // Trace this since it tends to be a bit slow on Windows.
   ScopedTrace setup_trace(TraceItem::TRACE_SETUP, "Fill Python Path");
 #if defined(OS_WIN)
-  // Find Python on the path so we can use the absolute path in the build.
-  const base::char16 kGetPython[] =
-      L"cmd.exe /c python -c \"import sys; print sys.executable\"";
-  std::string python_path;
-  if (base::GetAppOutput(kGetPython, &python_path)) {
-    base::TrimWhitespaceASCII(python_path, base::TRIM_ALL, &python_path);
-    if (scheduler_.verbose_logging())
-      scheduler_.Log("Found python", python_path);
-  } else {
+  base::FilePath python_path = FindWindowsPython();
+  if (python_path.empty()) {
     scheduler_.Log("WARNING", "Could not find python on path, using "
         "just \"python.exe\"");
-    python_path = "python.exe";
+    python_path = base::FilePath(L"python.exe");
   }
-  build_settings_.set_python_path(base::FilePath(base::UTF8ToUTF16(python_path))
-                                      .NormalizePathSeparatorsTo('/'));
+  build_settings_.set_python_path(python_path.NormalizePathSeparatorsTo('/'));
 #else
   build_settings_.set_python_path(base::FilePath("python"));
 #endif
 }
 
 bool Setup::RunConfigFile() {
   if (scheduler_.verbose_logging())
     scheduler_.Log("Got dotfile", FilePathToUTF8(dotfile_name_));
 
   dotfile_input_file_.reset(new InputFile(SourceFile("//.gn")));
@@ skipping 116 matching lines @@
       if (err.has_error()) {
         err.PrintToStdout();
         return false;
       }
     }
     build_settings_.set_exec_script_whitelist(whitelist.Pass());
   }
 
   return true;
 }