Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1462393002: Migrate `mockito` mocks to `typed_mock` (#24994). (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : master merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -81 lines) Patch
M pkg/analyzer_cli/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/test/driver_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer_cli/test/error_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer_cli/test/options_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer_cli/test/plugin_manager_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer_cli/test/reporter_test.dart View 1 chunk +65 lines, -66 lines 0 comments Download
M pkg/analyzer_cli/test/sdk_ext_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer_cli/test/strong_mode_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer_cli/test/super_mixin_test.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pquitslund
5 years, 1 month ago (2015-11-20 18:23:38 UTC) #2
scheglov
LGTM
5 years, 1 month ago (2015-11-20 18:24:56 UTC) #3
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-20 19:26:12 UTC) #4
pquitslund
5 years, 1 month ago (2015-11-20 21:58:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8d613feaf996f6d4020e46d9e5baf9a390bd6561 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698