Create security_interstitials::ControllerClient

Create security_interstitials::ControllerClient

This starts to split out UI-manipulating code from the
InterstitialPage-specific methods. The first in a series of
CLs.

BUG=488673
TBR=sky@chromium.org,davidben@chromium.org,isherman@chromium.org

Committed: https://crrev.com/9ad979c08e2f6f77ab637db5327e1b2a314a0395
Cr-Commit-Position: refs/heads/master@{#360999}

[felt, 2015-11-20 15:54:59]

Description was changed from

==========
Create security_interstitials::ControllerClient

BUG=
==========

to

==========
Create security_interstitials::ControllerClient

[Not ready for review yet]

BUG=
==========

[felt, 2015-11-20 19:25:31]

Description was changed from

==========
Create security_interstitials::ControllerClient

[Not ready for review yet]

BUG=
==========

to

==========
Create security_interstitials::ControllerClient



BUG=488673
==========

[felt, 2015-11-20 19:56:09]

Patchset #2 (id:20001) has been deleted

[felt, 2015-11-20 19:56:19]

Patchset #1 (id:1) has been deleted

[felt, 2015-11-20 20:04:27]

Description was changed from

==========
Create security_interstitials::ControllerClient



BUG=488673
==========

to

==========
Create security_interstitials::ControllerClient

This starts to split out UI-manipulating code from the
InterstitialPage-specific methods. The first in a series of
CLs.

BUG=488673
==========

[felt, 2015-11-20 20:04:27]

felt@chromium.org changed reviewers:
+ estark@chromium.org

[estark, 2015-11-21 00:46:59]

lgtm % a couple tiny things

https://codereview.chromium.org/1462353002/diff/60001/chrome/browser/intersti...
File chrome/browser/interstitials/security_interstitial_page.h (right):

https://codereview.chromium.org/1462353002/diff/60001/chrome/browser/intersti...
chrome/browser/interstitials/security_interstitial_page.h:67: void
OpenUrlInCurrentTab(const GURL& url) override;
add:

// security_interstitials::ControllerClient overrides

right above this line

https://codereview.chromium.org/1462353002/diff/60001/components/security_int...
File components/security_interstitials/core/controller_client.h (right):

https://codereview.chromium.org/1462353002/diff/60001/components/security_int...
components/security_interstitials/core/controller_client.h:52:
~ControllerClient();
virtual

[felt, 2015-11-21 01:03:07]

Description was changed from

==========
Create security_interstitials::ControllerClient

This starts to split out UI-manipulating code from the
InterstitialPage-specific methods. The first in a series of
CLs.

BUG=488673
==========

to

==========
Create security_interstitials::ControllerClient

This starts to split out UI-manipulating code from the
InterstitialPage-specific methods. The first in a series of
CLs.

BUG=488673
TBR=sky@chromium.org
==========

[felt, 2015-11-21 01:03:07]

felt@chromium.org changed reviewers:
+ sky@chromium.org

[felt, 2015-11-21 01:05:02]

Description was changed from

==========
Create security_interstitials::ControllerClient

This starts to split out UI-manipulating code from the
InterstitialPage-specific methods. The first in a series of
CLs.

BUG=488673
TBR=sky@chromium.org
==========

to

==========
Create security_interstitials::ControllerClient

This starts to split out UI-manipulating code from the
InterstitialPage-specific methods. The first in a series of
CLs.

BUG=488673
TBR=sky@chromium.org,davidben@chromium.org,isherman@chromium.org
==========

[felt, 2015-11-21 01:05:02]

felt@chromium.org changed reviewers:
+ davidben@chromium.org, isherman@chromium.org

[felt, 2015-11-21 01:06:48]

Adding reviewers as TBR:

sky@ for trivial change to download_feedback_dialog_view.cc

davidben@ for +net/base in DEPS

isherman@ for +components/google/core/browser in DEPS

https://codereview.chromium.org/1462353002/diff/60001/chrome/browser/intersti...
File chrome/browser/interstitials/security_interstitial_page.h (right):

https://codereview.chromium.org/1462353002/diff/60001/chrome/browser/intersti...
chrome/browser/interstitials/security_interstitial_page.h:67: void
OpenUrlInCurrentTab(const GURL& url) override;
On 2015/11/21 00:46:59, estark wrote:
> add:
> 
> // security_interstitials::ControllerClient overrides
> 
> right above this line

Done.

https://codereview.chromium.org/1462353002/diff/60001/components/security_int...
File components/security_interstitials/core/controller_client.h (right):

https://codereview.chromium.org/1462353002/diff/60001/components/security_int...
components/security_interstitials/core/controller_client.h:52:
~ControllerClient();
On 2015/11/21 00:46:59, estark wrote:
> virtual

Done.

[felt, 2015-11-21 01:07:06]

The CQ bit was checked by felt@chromium.org

[felt, 2015-11-21 01:07:06]

The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org
Link to the patchset: https://codereview.chromium.org/1462353002/#ps80001
(title: "Nits for estark")

[commit-bot: I haz the power, 2015-11-21 01:09:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1462353002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1462353002/80001

[Ilya Sherman, 2015-11-21 01:17:18]

DEPS LGTM

[davidben, 2015-11-21 01:47:19]

On 2015/11/21 01:06:48, felt wrote:
> davidben@ for +net/base in DEPS

lgtm.

net/base was in DEPS before actually. I'm guessing our presubmit tools get
confused because you had to add a trailing comma? That's kinda disappointing,
actually. You'd think we could just parse that list for real...

[sdefresne, 2015-11-21 01:53:53]

https://codereview.chromium.org/1462353002/diff/80001/components/security_int...
File components/security_interstitials/DEPS (right):

https://codereview.chromium.org/1462353002/diff/80001/components/security_int...
components/security_interstitials/DEPS:8: "+ui/base"
drive-by: if adding a coma cause the script to get confused, you may want to add
one here too...

[commit-bot: I haz the power, 2015-11-21 02:44:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-21 02:44:38]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[felt, 2015-11-21 02:46:25]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2015-11-21 02:48:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1462353002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1462353002/80001

[commit-bot: I haz the power, 2015-11-21 03:55:47]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-11-21 03:56:26]

Patchset 3 (id:??) landed as
https://crrev.com/9ad979c08e2f6f77ab637db5327e1b2a314a0395
Cr-Commit-Position: refs/heads/master@{#360999}