Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: pkg/compiler/lib/src/universe/universe.dart

Issue 1462333002: Revert "Register super field set explicitly in the universe." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/codegen.dart ('k') | pkg/compiler/lib/src/universe/use.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/universe/universe.dart
diff --git a/pkg/compiler/lib/src/universe/universe.dart b/pkg/compiler/lib/src/universe/universe.dart
index bd01e1b958976ba14df224208e1304d5a6c755a3..5a7ba20eb85a4571f16ea5c35cd598fca1c62f78 100644
--- a/pkg/compiler/lib/src/universe/universe.dart
+++ b/pkg/compiler/lib/src/universe/universe.dart
@@ -282,8 +282,7 @@ class Universe {
}
bool hasInvokedSetter(Element member, World world) {
- return _hasMatchingSelector(_invokedSetters[member.name], member, world) ||
- fieldSetters.contains(member);
+ return _hasMatchingSelector(_invokedSetters[member.name], member, world);
}
bool registerDynamicUse(DynamicUse dynamicUse) {
@@ -306,9 +305,7 @@ class Universe {
Map<Selector, SelectorConstraints> selectors = selectorMap.putIfAbsent(
name, () => new Maplet<Selector, SelectorConstraints>());
UniverseSelectorConstraints constraints = selectors.putIfAbsent(
- selector, () {
- return selectorConstraintsStrategy.createSelectorConstraints(selector);
- });
+ selector, () => selectorConstraintsStrategy.createSelectorConstraints(selector));
return constraints.addReceiverConstraint(mask);
}
@@ -367,7 +364,6 @@ class Universe {
case StaticUseKind.FIELD_GET:
fieldGetters.add(element);
break;
- case StaticUseKind.SUPER_FIELD_SET:
case StaticUseKind.FIELD_SET:
fieldSetters.add(element);
break;
« no previous file with comments | « pkg/compiler/lib/src/ssa/codegen.dart ('k') | pkg/compiler/lib/src/universe/use.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698