Issue 14623014: Remove use_system_speex logic from the mainline gyp file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14623014: Remove use_system_speex logic from the mainline gyp file. (Closed)

Created:
7 years, 7 months ago by Paweł Hajdan Jr.

Modified:
7 years, 7 months ago

Reviewers:
Satish, DaleCurtis

CC:
chromium-reviews, DaleCurtis

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/speex/

Visibility:
Public.

Remove use_system_speex logic from the mainline gyp file. It now lives in build/linux/unbundle BUG=226860 R=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198168

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -126 lines)			Patch
	M	speex.gyp	View		1 chunk	+79 lines, -126 lines	0 comments	Download

Total messages: 4 (0 generated)

DaleCurtis

I defer to satish@ since he approved this code in the first place. It looks ...

7 years, 7 months ago (2013-05-02 22:45:39 UTC) #2

DaleCurtis

lgtm since on second glance it appears to be a straight rip.

7 years, 7 months ago (2013-05-03 19:09:43 UTC) #3

Paweł Hajdan Jr.

7 years, 7 months ago (2013-05-03 19:22:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r198168 (presubmit successful).