Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 1462293002: Tweak RNG. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Tweak RNG. R=bmeurer@chromium.org Committed: https://crrev.com/623cbdc5432713badc9fe1d605c585aabb25876c Cr-Commit-Position: refs/heads/master@{#32132}

Patch Set 1 #

Patch Set 2 : fix bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -24 lines) Patch
M src/js/math.js View 1 2 chunks +19 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yang
5 years, 1 month ago (2015-11-20 07:02:42 UTC) #1
Benedikt Meurer
LGTM.
5 years, 1 month ago (2015-11-20 07:04:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462293002/1
5 years, 1 month ago (2015-11-20 07:10:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/10323)
5 years, 1 month ago (2015-11-20 07:21:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462293002/20001
5 years, 1 month ago (2015-11-20 07:26:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-20 07:55:31 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/623cbdc5432713badc9fe1d605c585aabb25876c Cr-Commit-Position: refs/heads/master@{#32132}
5 years, 1 month ago (2015-11-20 07:55:58 UTC) #11
mjmalone
5 years, 1 month ago (2015-11-20 23:37:26 UTC) #12
Message was sent while issue was closed.
On 2015/11/20 07:55:58, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/623cbdc5432713badc9fe1d605c585aabb25876c
> Cr-Commit-Position: refs/heads/master@{#32132}

Hey guys, I think this patch is still no good. The upper bits of an MWC are low
entropy, so the upper bits of your xor'd result I believe will be pretty low
entropy too. I could be reading the code wrong, but I'm guessing the top bit of
the result will be 0 most of the time. The right fix for MWC1616 to perturb the
upper bits would be to << one generator and then add the full output from the
second generator, mod 2^32. That way you use the (low entropy) upper bits from
one generator to perturb the (high entropy) lower bits of the other. The
algorithm isn't great in general though, as is being discussed elsewhere.

Powered by Google App Engine
This is Rietveld 408576698