Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 1462283003: X87: [runtime] Introduce a proper %NewArray runtime entry. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Introduce a proper %NewArray runtime entry. port ceade6cf239e0773213d53d55c36b19231c820b5 (r32131) original commit message: This adds a new %NewArray runtime entry, which constructs a new JSArray and does the subclassing correctly (to the same degree that %NewObject does currently), and also deals properly with the AllocationSite feedback mechanism. This runtime entry will be used by TurboFan and is also used as a fallback in the subclassing case in the stub currently. BUG= Committed: https://crrev.com/ea1d0a61be646970bc4bc51db919b020df562bf5 Cr-Commit-Position: refs/heads/master@{#32160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +11 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-20 09:15:55 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-23 02:56:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462283003/1
5 years, 1 month ago (2015-11-23 02:56:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 03:15:46 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 03:16:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea1d0a61be646970bc4bc51db919b020df562bf5
Cr-Commit-Position: refs/heads/master@{#32160}

Powered by Google App Engine
This is Rietveld 408576698