chrome/test/BUILD.gn - Issue 1462243002: GN: Support building liblouis library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/BUILD.gn

Issue 1462243002: GN: Support building liblouis library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review feedback incorporated Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/BUILD.gn

diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn

index 1e43a95f354e1a732e30472a852331e82077ad5c..6f14587b6f27d217b48a543f37e81b3faf498a55 100644

--- a/chrome/test/BUILD.gn

+++ b/chrome/test/BUILD.gn

@@ -997,10 +997,8 @@ if (!is_android) {

]

if (is_chromeos) {

sources += [ "//third_party/liblouis/nacl_wrapper/liblouis_wrapper_browsertest.cc" ]

- deps += [

- "//chrome/browser/chromeos",

- #'../third_party/liblouis/liblouis_nacl.gyp:liblouis_test_data', TODO(GYP) bug 512906

- ]

+ deps += [ "//chrome/browser/chromeos" ]

+ data_deps += [ "//third_party/liblouis:liblouis_test_data" ]

}

if (is_win || is_linux) {