Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1462213002: Use std::tie() for operator< in content/ (Closed)

Created:
5 years, 1 month ago by jsbell
Modified:
5 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, loading-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use std::tie() for operator< in content/ Simplify the code for operator< when comparing multiple members using a common std::tie idiom. BUG=555171 R=jochen@chromium.org Committed: https://crrev.com/71dafdfe7183b9b016460ceb0d1ce184b7aee341 Cr-Commit-Position: refs/heads/master@{#360883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M content/browser/host_zoom_map_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/loader/global_routing_id.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/media/webrtc_identity_store_backend.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/public/browser/desktop_media_id.h View 2 chunks +4 lines, -5 lines 0 comments Download
M content/public/browser/global_request_id.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/pepper/host_var_tracker.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jsbell
jochen@ - please take a look?
5 years, 1 month ago (2015-11-19 22:16:19 UTC) #1
kinuko
Just saw this, drive-by lgtm
5 years, 1 month ago (2015-11-20 04:24:15 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-20 13:37:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462213002/1
5 years, 1 month ago (2015-11-20 19:05:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 19:40:45 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 19:42:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71dafdfe7183b9b016460ceb0d1ce184b7aee341
Cr-Commit-Position: refs/heads/master@{#360883}

Powered by Google App Engine
This is Rietveld 408576698