components: Move PrefRegistrySyncable into user_prefs namespace.

chrome/browser/bookmarks/bookmark_prompt_prefs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bookmarks/bookmark_prompt_prefs.h"
 
 #include "base/prefs/pref_service.h"
 #include "chrome/common/pref_names.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 
@@ skipping 15 matching lines @@
 void BookmarkPromptPrefs::IncrementPromptImpressionCount() {
   prefs_->SetInteger(prefs::kBookmarkPromptImpressionCount,
                      GetPromptImpressionCount() + 1);
 }
 
 bool BookmarkPromptPrefs::IsBookmarkPromptEnabled() const {
   return prefs_->GetBoolean(prefs::kBookmarkPromptEnabled);
 }
 
 // static
-void BookmarkPromptPrefs::RegisterUserPrefs(PrefRegistrySyncable* registry) {
+void BookmarkPromptPrefs::RegisterUserPrefs(
+    user_prefs::PrefRegistrySyncable* registry) {

[Jói, 2013/05/04 21:31:47]

For .cc files where there are more than one or two usages of
user_prefs::PrefRegistrySyncable, I would suggest a using declaration near the
top of the file, similar to what is commonly done for e.g.
content::BrowserThread.

For places where there are just a handful of usages, it's a judgment call, so up
to you whether to change this file for instance.

[tfarina, 2013/05/05 00:45:59]

I'm going with user_prefs:: for now because it was easier for me that way to see
if I was missing something. I'll look into using "using
user_prefs::PrefRegistrySyncable;" in a follow up CL.

   // We always register preferences without checking FieldTrial, because
   // we may not receive field trial list from the server yet.
-  registry->RegisterBooleanPref(prefs::kBookmarkPromptEnabled, true,
-                                PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterIntegerPref(prefs::kBookmarkPromptImpressionCount, 0,
-                                PrefRegistrySyncable::UNSYNCABLE_PREF);
+  registry->RegisterBooleanPref(
+      prefs::kBookmarkPromptEnabled,
+      true,
+      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+  registry->RegisterIntegerPref(
+      prefs::kBookmarkPromptImpressionCount,
+      0,
+      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
 }