Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1462143003: Revert of Fix TexStorage3D with compressed ETC2/EAC formats (Closed)

Created:
5 years, 1 month ago by Jamie Madill
Modified:
5 years, 1 month ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix TexStorage3D with compressed ETC2/EAC formats (patchset #3 id:40001 of https://codereview.chromium.org/1463503002/ ) Reason for revert: Failing Windows WebGL 2 CTS: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28NVIDIA%29/builds/19403 WebglConformance.conformance2_textures_misc_tex_storage_compressed_formats: Failure: getError expected: NO_ERROR. Was INVALID_OPERATION : texStorage3D should succeed for COMPRESSED_R11_EAC FAIL getError expected: NO_ERROR. Was INVALID_OPERATION : texStorage3D should succeed for COMPRESSED_R11_EAC getError expected: NO_ERROR. Was INVALID_OPERATION : texStorage3D should succeed for COMPRESSED_SIGNED_R11_EAC FAIL getError expected: NO_ERROR. Was INVALID_OPERATION : texStorage3D should succeed for COMPRESSED_SIGNED_R11_EAC getError expected: NO_ERROR. Was INVALID_OPERATION : texStorage3D should succeed for COMPRESSED_RG11_EAC etc Original issue's description: > Fix TexStorage3D with compressed ETC2/EAC formats > > These formats don't work for TexStorage3D if target is TEXTURE_3D. > TEXTURE_2D_ARRAY should work. > > BUG=295792 > TEST=conformance2/textures/misc/tex-storage-compressed-formats.html > > Committed: https://crrev.com/5b5a54a2d7c287e09f644d04e29718b310949221 > Cr-Commit-Position: refs/heads/master@{#360760} TBR=kbr@chromium.org,zmo@chromium.org,bajones@chromium.org,qiankun.miao@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=295792 Committed: https://crrev.com/21c9153893f4a238cb65ec353a80ff9483b1d130 Cr-Commit-Position: refs/heads/master@{#360839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jamie Madill
Created Revert of Fix TexStorage3D with compressed ETC2/EAC formats
5 years, 1 month ago (2015-11-20 16:50:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462143003/1
5 years, 1 month ago (2015-11-20 16:51:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 16:52:21 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 16:53:24 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21c9153893f4a238cb65ec353a80ff9483b1d130
Cr-Commit-Position: refs/heads/master@{#360839}

Powered by Google App Engine
This is Rietveld 408576698