Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: components/mus/public/cpp/lib/window.cc

Issue 1462123002: views/mus: Set-up transient windows correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tot.merge Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/mus/public/cpp/tests/window_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/mus/public/cpp/lib/window.cc
diff --git a/components/mus/public/cpp/lib/window.cc b/components/mus/public/cpp/lib/window.cc
index 46291b0a68092a0327e81f0c5acdde3fc2355275..94d598b9ca72fcda06a33977fb3fdc0ea6bc1e28 100644
--- a/components/mus/public/cpp/lib/window.cc
+++ b/components/mus/public/cpp/lib/window.cc
@@ -778,6 +778,8 @@ bool Window::ReorderImpl(Window* window,
DCHECK(relative);
DCHECK_NE(window, relative);
DCHECK_EQ(window->parent(), relative->parent());
+ if (!window->parent())
+ return false;
sadrul 2016/01/11 21:37:34 There is probably a bug that the WS sends reorder
sadrul 2016/01/12 21:50:48 Put up https://codereview.chromium.org/1580193002/
if (!AdjustStackingForTransientWindows(&window, &relative, &direction,
window->stacking_target_))
« no previous file with comments | « no previous file | components/mus/public/cpp/tests/window_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698