components/mus/public/cpp/lib/window.cc - Issue 1462123002: views/mus: Set-up transient windows correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/public/cpp/lib/window.cc

Issue 1462123002: views/mus: Set-up transient windows correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/mus/public/cpp/lib/window.cc

diff --git a/components/mus/public/cpp/lib/window.cc b/components/mus/public/cpp/lib/window.cc

index e2ac0c8f4a1b7f2170bfef8076aee75a21d7f44e..e953ba8fb7809c3502a8508d7aff9d3c4d8d282e 100644

--- a/components/mus/public/cpp/lib/window.cc

+++ b/components/mus/public/cpp/lib/window.cc

@@ -270,16 +270,12 @@ void Window::RemoveChild(Window* child) {

}

void Window::AddTransientWindow(Window* transient_window) {

- if (connection_)

- CHECK_EQ(transient_window->connection(), connection_);

LocalAddTransientWindow(transient_window);

if (connection_)

tree_client()->AddTransientWindow(this, transient_window->id());

}

void Window::RemoveTransientWindow(Window* transient_window) {

- if (connection_)

- CHECK_EQ(transient_window->connection(), connection_);

LocalRemoveTransientWindow(transient_window);

if (connection_)

tree_client()->RemoveTransientWindowFromParent(transient_window);