Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1462083003: Add //mojo/edk/platform and move platform_task_runners.h there. (Closed)

Created:
5 years, 1 month ago by viettrungluu
Modified:
5 years, 1 month ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add //mojo/edk/platform and move platform_task_runners.h there. (Rename it to task_runners.h and mojo::embedder::PlatformTaskRunner to mojo::platform::TaskRunner.) I'll move other platform_* stuff separately and appropriately. R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6bcf711e9e84c675fab905b5524d50dcf2afda02

Patch Set 1 #

Patch Set 2 : update readme #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -196 lines) Patch
M mojo/edk/README.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/base_edk/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/base_edk/platform_task_runner_impl.h View 2 chunks +5 lines, -6 lines 0 comments Download
M mojo/edk/embedder/BUILD.gn View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/edk/embedder/embedder.h View 6 chunks +7 lines, -7 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 7 chunks +8 lines, -7 lines 0 comments Download
M mojo/edk/embedder/embedder_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
D mojo/edk/embedder/platform_task_runner.h View 1 chunk +0 lines, -47 lines 0 comments Download
A + mojo/edk/platform/BUILD.gn View 1 chunk +6 lines, -4 lines 0 comments Download
A + mojo/edk/platform/task_runner.h View 2 chunks +9 lines, -10 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/channel_manager.h View 7 chunks +10 lines, -11 lines 0 comments Download
M mojo/edk/system/channel_manager.cc View 10 chunks +15 lines, -19 lines 0 comments Download
M mojo/edk/system/channel_manager_unittest.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M mojo/edk/system/connection_manager_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M mojo/edk/system/ipc_support.h View 5 chunks +16 lines, -16 lines 1 comment Download
M mojo/edk/system/ipc_support.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M mojo/edk/system/master_connection_manager.h View 3 chunks +4 lines, -5 lines 0 comments Download
M mojo/edk/system/master_connection_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/system/slave_connection_manager.h View 3 chunks +5 lines, -6 lines 0 comments Download
M mojo/edk/system/slave_connection_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/system/test/test_io_thread.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/test/scoped_ipc_support.h View 5 chunks +8 lines, -8 lines 0 comments Download
M mojo/edk/test/scoped_ipc_support.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M shell/child_main.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M shell/task_runners.h View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
viettrungluu
5 years, 1 month ago (2015-11-19 20:21:27 UTC) #1
viettrungluu
ping
5 years, 1 month ago (2015-11-20 21:45:31 UTC) #2
viettrungluu
-> vardhan
5 years, 1 month ago (2015-11-23 18:11:49 UTC) #5
viettrungluu
-> kulakowski
5 years, 1 month ago (2015-11-23 19:08:18 UTC) #8
kulakowski
lgtm https://codereview.chromium.org/1462083003/diff/20001/mojo/edk/system/ipc_support.h File mojo/edk/system/ipc_support.h (right): https://codereview.chromium.org/1462083003/diff/20001/mojo/edk/system/ipc_support.h#newcode128 mojo/edk/system/ipc_support.h:128: const util::RefPtr<platform::TaskRunner>& delegate_thread_task_runner() Nice.
5 years, 1 month ago (2015-11-23 19:11:22 UTC) #9
kulakowski
lgtm https://codereview.chromium.org/1462083003/diff/20001/mojo/edk/system/ipc_support.h File mojo/edk/system/ipc_support.h (right): https://codereview.chromium.org/1462083003/diff/20001/mojo/edk/system/ipc_support.h#newcode128 mojo/edk/system/ipc_support.h:128: const util::RefPtr<platform::TaskRunner>& delegate_thread_task_runner() Nice.
5 years, 1 month ago (2015-11-23 19:11:22 UTC) #10
viettrungluu
5 years, 1 month ago (2015-11-23 20:47:00 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6bcf711e9e84c675fab905b5524d50dcf2afda02 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698