Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1462063004: Move VideoFramePump to remoting/protocol (Closed)

Created:
5 years, 1 month ago by Sergey Ulanov
Modified:
5 years, 1 month ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move VideoFramePump to remoting/protocol VideoFramePump will not be used for WebRTC-based connection. In a separate change I plan to move creation of the VideoFramePump to IceConnectionToHost so the host layer will not need to know when VideoFramePump needs to be used. Committed: https://crrev.com/4d2080079417529d000f3ed13f144ba0b4a08a86 Cr-Commit-Position: refs/heads/master@{#361205}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -1524 lines) Patch
M remoting/host/BUILD.gn View 7 chunks +4 lines, -8 lines 0 comments Download
D remoting/host/capture_scheduler.h View 1 chunk +0 lines, -113 lines 0 comments Download
D remoting/host/capture_scheduler.cc View 1 chunk +0 lines, -181 lines 0 comments Download
D remoting/host/capture_scheduler_unittest.cc View 1 chunk +0 lines, -195 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/client_session.h View 2 chunks +4 lines, -1 line 0 comments Download
M remoting/host/client_session.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/desktop_process_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
D remoting/host/fake_desktop_capturer.h View 1 chunk +0 lines, -49 lines 0 comments Download
D remoting/host/fake_desktop_capturer.cc View 1 chunk +0 lines, -153 lines 0 comments Download
M remoting/host/fake_desktop_environment.h View 1 5 chunks +9 lines, -9 lines 0 comments Download
M remoting/host/fake_desktop_environment.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/host_mock_objects.h View 1 chunk +0 lines, -12 lines 0 comments Download
M remoting/host/host_mock_objects.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M remoting/host/ipc_desktop_environment_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/shaped_desktop_capturer_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
D remoting/host/video_frame_pump.h View 1 chunk +0 lines, -197 lines 0 comments Download
D remoting/host/video_frame_pump.cc View 1 chunk +0 lines, -256 lines 0 comments Download
D remoting/host/video_frame_pump_unittest.cc View 1 chunk +0 lines, -239 lines 0 comments Download
M remoting/protocol/BUILD.gn View 4 chunks +20 lines, -17 lines 0 comments Download
A + remoting/protocol/capture_scheduler.h View 4 chunks +9 lines, -5 lines 0 comments Download
A + remoting/protocol/capture_scheduler.cc View 3 chunks +4 lines, -2 lines 0 comments Download
A + remoting/protocol/capture_scheduler_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
A + remoting/protocol/fake_desktop_capturer.h View 1 2 chunks +7 lines, -4 lines 0 comments Download
A + remoting/protocol/fake_desktop_capturer.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
A + remoting/protocol/video_frame_pump.h View 4 chunks +6 lines, -6 lines 0 comments Download
A + remoting/protocol/video_frame_pump.cc View 3 chunks +3 lines, -1 line 0 comments Download
A + remoting/protocol/video_frame_pump_unittest.cc View 1 2 3 11 chunks +25 lines, -23 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M remoting/remoting_nacl.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/remoting_srcs.gypi View 2 chunks +14 lines, -6 lines 0 comments Download
M remoting/remoting_test.gypi View 1 2 6 chunks +4 lines, -4 lines 0 comments Download
M remoting/test/protocol_perftest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Sergey Ulanov
5 years, 1 month ago (2015-11-20 01:21:17 UTC) #2
kelvinp
lgtm https://codereview.chromium.org/1462063004/diff/1/remoting/protocol/fake_desktop_capturer.cc File remoting/protocol/fake_desktop_capturer.cc (right): https://codereview.chromium.org/1462063004/diff/1/remoting/protocol/fake_desktop_capturer.cc#newcode122 remoting/protocol/fake_desktop_capturer.cc:122: FakeDesktopCapturer::FakeDesktopCapturer() namespace protocol { https://codereview.chromium.org/1462063004/diff/1/remoting/protocol/fake_desktop_capturer.h File remoting/protocol/fake_desktop_capturer.h (right): ...
5 years, 1 month ago (2015-11-20 21:14:42 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/1462063004/diff/1/remoting/protocol/fake_desktop_capturer.cc File remoting/protocol/fake_desktop_capturer.cc (right): https://codereview.chromium.org/1462063004/diff/1/remoting/protocol/fake_desktop_capturer.cc#newcode122 remoting/protocol/fake_desktop_capturer.cc:122: FakeDesktopCapturer::FakeDesktopCapturer() On 2015/11/20 21:14:42, kelvinp wrote: > namespace protocol ...
5 years, 1 month ago (2015-11-21 01:41:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462063004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462063004/20001
5 years, 1 month ago (2015-11-21 01:42:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/138466) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 1 month ago (2015-11-21 02:10:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462063004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462063004/40001
5 years, 1 month ago (2015-11-23 19:56:31 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/144967) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 1 month ago (2015-11-23 20:39:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462063004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462063004/60001
5 years, 1 month ago (2015-11-23 20:54:03 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-23 22:27:51 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 22:29:17 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4d2080079417529d000f3ed13f144ba0b4a08a86
Cr-Commit-Position: refs/heads/master@{#361205}

Powered by Google App Engine
This is Rietveld 408576698