Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 146203002: [NaCl SDK Docs] Remove table-of-contents from generated pages. (Closed)

Created:
6 years, 11 months ago by binji
Modified:
4 years, 4 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[NaCl SDK Docs] Remove table-of-contents from generated pages. We don't want the TOC at the top of the chromesite pages, but we do for the devsite pages. The table-of-contents is in the .rst file, but we don't want to remove it in case we need to generate devsite documentation again. The easy hack for now is to set the style of the element to "display: none". Also, remove doc_generated/.buildinfo. This file should not be checked in. BUG=none R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246928

Patch Set 1 #

Patch Set 2 : add .gitignore for .buildinfo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -85 lines) Patch
D native_client_sdk/doc_generated/.buildinfo View 1 chunk +0 lines, -4 lines 0 comments Download
A native_client_sdk/doc_generated/.gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/doc_generated/community/security-contest/contest-announcement.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/community/security-contest/contest-faq.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/community/security-contest/index.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/application-structure.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/audio.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/file-io.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/message-system.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/nacl_io.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/native-client-modules.html View 1 chunk +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/progress-events.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/url-loading.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/coding/view-focus-input-events.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/building.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/debugging.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/dynamic-loading.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/running.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/vs-addin.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/distributing.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/tutorial/tutorial-part1.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/tutorial/tutorial-part2.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/faq.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/nacl-and-pnacl.html View 1 chunk +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/overview.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/reference/nacl-manifest-format.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/reference/pnacl-bitcode-abi.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/rest-devsite-examples.html View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/_sphinxext/chromesite_builder.py View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
binji
6 years, 11 months ago (2014-01-23 23:52:19 UTC) #1
Sam Clegg
So is there a corresponding generator-side change? We don't want manual modification to generated files ...
6 years, 11 months ago (2014-01-24 01:06:32 UTC) #2
binji
On 2014/01/24 01:06:32, Sam Clegg wrote: > So is there a corresponding generator-side change? We ...
6 years, 11 months ago (2014-01-24 16:19:47 UTC) #3
Sam Clegg
On 2014/01/24 16:19:47, binji wrote: > On 2014/01/24 01:06:32, Sam Clegg wrote: > > So ...
6 years, 11 months ago (2014-01-24 18:04:43 UTC) #4
binji
Committed patchset #2 manually as r246928 (presubmit successful).
6 years, 11 months ago (2014-01-24 18:11:03 UTC) #5
natalia stachniuk
4 years, 4 months ago (2016-08-24 02:16:04 UTC) #7
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698