Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1462003002: Changed MediaStreamRemoteVideoSource unit test to use correct WebRtcVideoFrame.InitToBlack (Closed)

Created:
5 years, 1 month ago by perkj_chrome
Modified:
5 years, 1 month ago
Reviewers:
magjed_chromium
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed MediaStreamRemoteVideoSourceTest unit test to use correct WebRtcVideoFrame.InitToBlack The InitToBlack function used in this unit tests has been chagned. The elapsed_time argument has been removed. Committed: https://crrev.com/6c3f5808ff3969db53bed32f47fd6486df1bb680 Cr-Commit-Position: refs/heads/master@{#360611}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
perkj_chrome
please
5 years, 1 month ago (2015-11-19 13:26:46 UTC) #3
magjed_chromium
lgtm
5 years, 1 month ago (2015-11-19 14:45:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462003002/1
5 years, 1 month ago (2015-11-19 16:10:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/98382)
5 years, 1 month ago (2015-11-19 16:29:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1462003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1462003002/20001
5 years, 1 month ago (2015-11-19 16:50:20 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 17:15:29 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 17:16:38 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c3f5808ff3969db53bed32f47fd6486df1bb680
Cr-Commit-Position: refs/heads/master@{#360611}

Powered by Google App Engine
This is Rietveld 408576698