Chromium Code Reviews
Help | Chromium Project | Sign in
(877)

Issue 1462001: Use internal pdf plugin with --internal-pdf (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by jam
Modified:
2 years, 11 months ago
CC:
brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Use internal pdf plugin with --internal-pdf

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42886

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Lint Patch
M chrome/browser/plugin_service.cc View 1 chunk +7 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M chrome/common/chrome_paths.h View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M chrome/common/chrome_paths.cc View 1 chunk +12 lines, -0 lines 0 comments 1 errors Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M chrome/renderer/render_process_impl.cc View 1 2 chunks +17 lines, -0 lines 0 comments 0 errors Download
M chrome/renderer/render_view.cc View 1 chunk +5 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 2
jam
(removed chromium-reviews) I'd like to check this in so that others can try out the ...
4 years, 1 month ago #1
cpu_(out until 23rd)
4 years, 1 month ago #2
lgtm

The one nit, that you should fix at some point is to have it named like
xxx32.dll so if we go to 64 bits we keep uniform names.

btw, what we agreed for the 'other' one was gcxxx32.dll but I don't care that
much.



On 2010/03/26 20:20:01, John Abd-El-Malek wrote:
> (removed chromium-reviews)
> 
> I'd like to check this in so that others can try out the pdf plugin and the
devs
> working on it don't have to keep patching this in each checkout.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6