third_party/WebKit/Source/core/events/EventTarget.idl - Issue 1461993002: Make addEventListener/removeEventListener arguments non-optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/EventTarget.idl

Issue 1461993002: Make addEventListener/removeEventListener arguments non-optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: drop the use counters Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/EventTarget.idl

diff --git a/third_party/WebKit/Source/core/events/EventTarget.idl b/third_party/WebKit/Source/core/events/EventTarget.idl

index 9798b1282d34ee1f45f43ba4fd87bc3fd5797f87..602c41ad27100d2447268641f262ceb0ee91a14d 100644

--- a/third_party/WebKit/Source/core/events/EventTarget.idl

+++ b/third_party/WebKit/Source/core/events/EventTarget.idl

@@ -25,10 +25,7 @@

WillBeGarbageCollected,

Exposed=(Window,Worker)

] interface EventTarget {

- // FIXME: first 2 args should be required, but throwing TypeError breaks

- // legacy content. http://crbug.com/353484

- // FIXME: type should not be nullable.

- [Custom] void addEventListener(optional DOMString? type = null, optional EventListener? listener = null, optional (EventListenerOptions or boolean) options);

- [Custom] void removeEventListener(optional DOMString? type = null, optional EventListener? listener = null, optional (EventListenerOptions or boolean) options);

+ [Custom] void addEventListener(DOMString type, EventListener? listener, optional (EventListenerOptions or boolean) options);

+ [Custom] void removeEventListener(DOMString type, EventListener? listener, optional (EventListenerOptions or boolean) options);

[ImplementedAs=dispatchEventForBindings, RaisesException] boolean dispatchEvent(Event event);

};