Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/event-target-arguments.html

Issue 1461993002: Make addEventListener/removeEventListener arguments non-optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: drop the use counters Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/event-target-arguments.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/event-target-arguments.html b/third_party/WebKit/LayoutTests/fast/dom/event-target-arguments.html
index 4ed6589d4d20b708b8d3795565c1d5b118f76761..b7d8a80ab1bf3905d1672dacd2a880929a1975fd 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/event-target-arguments.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/event-target-arguments.html
@@ -9,75 +9,39 @@ function listener(event)
}
debug('Signature:')
-debug('void addEventListener(DOMString type, EventListener listener, optional boolean useCapture)');
-// FIXME: should throw on missing arguments: http://crbug.com/353484
-// shouldThrow('document.addEventListener()');
-// shouldThrow('document.addEventListener("foo")');
-var AddEventListenerNoArguments = 656;
-shouldBeFalse('internals.isUseCounted(document, AddEventListenerNoArguments)');
-shouldBe('document.addEventListener()', 'undefined');
-shouldBeTrue('internals.isUseCounted(document, AddEventListenerNoArguments)');
-var AddEventListenerOneArgument = 657;
-shouldBeFalse('internals.isUseCounted(document, AddEventListenerOneArgument)');
-shouldBe('document.addEventListener("foo")', 'undefined');
-shouldBeTrue('internals.isUseCounted(document, AddEventListenerOneArgument)');
+debug('void addEventListener(DOMString type, EventListener? listener, optional boolean useCapture)');
+shouldThrow('document.addEventListener()');
+shouldThrow('document.addEventListener("foo")');
shouldNotThrow('document.addEventListener("foo", listener)');
shouldNotThrow('document.addEventListener("", listener)');
shouldNotThrow('document.addEventListener("", function(){})');
shouldNotThrow('document.addEventListener("bar", listener, false)');
shouldNotThrow('document.addEventListener("bar", listener, true)');
// null
-shouldBe('document.addEventListener(null)', 'undefined');
-shouldNotThrow('document.addEventListener(null, listener)'); // converted to "null"
-// FIXME: throw on |null|: http://crbug.com/249598
-// shouldThrow('document.addEventListener("foo", null)');
-shouldBe('document.addEventListener("foo", null)', 'undefined');
+shouldNotThrow('document.addEventListener(null, listener)');
+shouldNotThrow('document.addEventListener("foo", null)');
shouldNotThrow('document.addEventListener("zork", listener, null)');
// undefined
-// FIXME: behavior of undefined for mandatory arguments is unclear, but
-// probably should throw
-// https://www.w3.org/Bugs/Public/show_bug.cgi?id=23532
-shouldBe('document.addEventListener(undefined)', 'undefined');
-// shouldThrow('document.addEventListener(undefined, listener)');
-// shouldThrow('document.addEventListener("foo", undefined)');
-shouldBe('document.addEventListener(undefined, listener)', 'undefined');
-shouldBe('document.addEventListener("foo", undefined)', 'undefined');
+shouldNotThrow('document.addEventListener(undefined, listener)');
+shouldNotThrow('document.addEventListener("foo", undefined)');
shouldNotThrow('document.addEventListener("zork", listener, undefined)');
debug('');
debug('Signature:');
-debug('void removeEventListener(DOMString type, EventListener listener, optional boolean useCapture)');
-// FIXME: should throw on missing arguments: http://crbug.com/353484
-// shouldThrow('document.removeEventListener()');
-// shouldThrow('document.removeEventListener("foo")');
-var RemoveEventListenerNoArguments = 658;
-shouldBeFalse('internals.isUseCounted(document, RemoveEventListenerNoArguments)');
-shouldBe('document.removeEventListener()', 'undefined');
-shouldBeTrue('internals.isUseCounted(document, RemoveEventListenerNoArguments)');
-var RemoveEventListenerOneArgument = 659;
-shouldBeFalse('internals.isUseCounted(document, RemoveEventListenerOneArgument)');
-shouldBe('document.removeEventListener("foo")', 'undefined');
-shouldBeTrue('internals.isUseCounted(document, RemoveEventListenerOneArgument)');
+debug('void removeEventListener(DOMString type, EventListener? listener, optional boolean useCapture)');
+shouldThrow('document.removeEventListener()');
+shouldThrow('document.removeEventListener("foo")');
shouldNotThrow('document.removeEventListener("foo", listener)');
shouldNotThrow('document.removeEventListener("foo", listener, true)');
shouldNotThrow('document.removeEventListener("bar", listener, false)');
shouldNotThrow('document.removeEventListener("bar", listener, false)');
shouldNotThrow('document.removeEventListener("bar", listener, true)');
// null
-shouldBe('document.removeEventListener(null)', 'undefined');
-shouldNotThrow('document.removeEventListener(null, listener)'); // converted to "null"
-// FIXME: throw on |null|: http://crbug.com/249598
-// shouldThrow('document.removeEventListener("foo", null)');
-shouldBe('document.removeEventListener("foo", null)', 'undefined');
+shouldNotThrow('document.removeEventListener(null, listener)');
+shouldNotThrow('document.removeEventListener("foo", null)');
shouldNotThrow('document.removeEventListener("zork", listener, null)');
// undefined
-// FIXME: behavior of undefined for mandatory arguments is unclear, but
-// probably should throw
-// https://www.w3.org/Bugs/Public/show_bug.cgi?id=23532
-shouldBe('document.removeEventListener(undefined)', 'undefined');
-// shouldthrow('document.removeeventlistener("foo", undefined)');
-// shouldthrow('document.removeeventlistener(undefined, listener)');
-shouldBe('document.removeEventListener(undefined, listener)', 'undefined');
-shouldBe('document.removeEventListener("foo", undefined)', 'undefined');
+shouldNotThrow('document.removeEventListener(undefined, listener)');
+shouldNotThrow('document.removeEventListener("foo", undefined)');
shouldNotThrow('document.removeEventListener("zork", listener, undefined)');
</script>

Powered by Google App Engine
This is Rietveld 408576698