Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1461973002: [turbofan] Make new.target explicit in JSCallDescriptor. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer, oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make new.target explicit in JSCallDescriptor. This adds an explicit parameter to the call descriptor having kind kJSCallFunction representing the new.target value. Note that for now this parameter is not yet passed in and hence cannot be used yet. Also contains some refactoring of how parameter index value are calculated, establishing Linkage as the central point for such index computations. This is a preparatory CL to allows us passing new.target in a register instead of via a side-channel through the construct stub frame. R=bmeurer@chromium.org BUG=v8:4544 LOG=n Committed: https://crrev.com/0227857d26df19bce8588923f9be4cd5ef07269c Cr-Commit-Position: refs/heads/master@{#32112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -49 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/js-frame-specialization.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/compiler/js-inlining.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-inlining.cc View 5 chunks +18 lines, -11 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/linkage.h View 2 chunks +19 lines, -4 lines 0 comments Download
M src/compiler/linkage.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/bytecode-graph-builder-unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
Benedikt: PTAL. Orion: FYI.
5 years, 1 month ago (2015-11-19 12:18:37 UTC) #3
Benedikt Meurer
Nice. LGTM.
5 years, 1 month ago (2015-11-19 12:44:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461973002/1
5 years, 1 month ago (2015-11-19 12:46:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 12:47:35 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 12:48:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0227857d26df19bce8588923f9be4cd5ef07269c
Cr-Commit-Position: refs/heads/master@{#32112}

Powered by Google App Engine
This is Rietveld 408576698