Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1461963002: [turbofan] Simplify NumberTo(U)Int32 handling in representation inference. (Closed)

Created:
5 years, 1 month ago by Jarin
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Simplify NumberTo(U)Int32 handling in representation inference. Committed: https://crrev.com/6adea83502b676ed1d52e5c7c986aeb324a904e0 Cr-Commit-Position: refs/heads/master@{#32113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -52 lines) Patch
M src/compiler/representation-change.h View 2 chunks +4 lines, -12 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +4 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please?
5 years, 1 month ago (2015-11-19 11:56:23 UTC) #2
Benedikt Meurer
Awesome cleanup. LGTM.
5 years, 1 month ago (2015-11-19 12:56:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461963002/1
5 years, 1 month ago (2015-11-19 12:57:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 12:58:35 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 12:59:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6adea83502b676ed1d52e5c7c986aeb324a904e0
Cr-Commit-Position: refs/heads/master@{#32113}

Powered by Google App Engine
This is Rietveld 408576698