Source/core/html/HTMLFrameOwnerElement.cpp - Issue 146193003: Remove SVGDocument binding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFrameOwnerElement.cpp

Issue 146193003: Remove SVGDocument binding (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix some of the comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLFrameOwnerElement.cpp

diff --git a/Source/core/html/HTMLFrameOwnerElement.cpp b/Source/core/html/HTMLFrameOwnerElement.cpp

index aaa73ff224c80348e007abd59ae74f8b905a0a51..5767885e13bfb5a4dee3caf6f4405013c8ac7d39 100644

--- a/Source/core/html/HTMLFrameOwnerElement.cpp

+++ b/Source/core/html/HTMLFrameOwnerElement.cpp

@@ -113,7 +113,7 @@ bool HTMLFrameOwnerElement::isKeyboardFocusable() const

return m_contentFrame && HTMLElement::isKeyboardFocusable();

}

-SVGDocument* HTMLFrameOwnerElement::getSVGDocument(ExceptionState& exceptionState) const

+Document* HTMLFrameOwnerElement::getSVGDocument(ExceptionState& exceptionState) const

Inactive 2014/01/24 00:23:47 I don't think this change is needed.

{

Document* doc = contentDocument();

if (doc && doc->isSVGDocument())