Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1461923004: Avoid devolving to a path when conservative clipping with RRects (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Avoid devolving to a path when conservative clipping with RRects Committed: https://skia.googlesource.com/skia/+/125f19a2964c31a660256132acbce60e8a3e6752

Patch Set 1 #

Patch Set 2 : Simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M src/core/SkCanvas.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/core/SkRasterClip.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/core/SkRasterClip.cpp View 1 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
robertphillips
5 years, 1 month ago (2015-11-20 19:20:45 UTC) #2
robertphillips
PTAL - unfortunately the SkPath version of 'op' doesn't easily fold into the SkRect version ...
5 years, 1 month ago (2015-11-20 19:32:32 UTC) #3
robertphillips
ping
5 years, 1 month ago (2015-11-23 13:40:03 UTC) #4
reed1
lgtm
5 years, 1 month ago (2015-11-23 16:13:11 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461923004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461923004/20001
5 years, 1 month ago (2015-11-23 16:14:49 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-23 16:27:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461923004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461923004/20001
5 years, 1 month ago (2015-11-23 16:59:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/125f19a2964c31a660256132acbce60e8a3e6752
5 years, 1 month ago (2015-11-23 17:00:19 UTC) #12
scroggo
On 2015/11/23 17:00:19, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as ...
5 years ago (2015-11-30 19:36:55 UTC) #13
robertphillips
Haha - it looks like it. I'm pretty surprised it had such a noticeable effect.
5 years ago (2015-11-30 19:59:09 UTC) #14
robertphillips
5 years ago (2015-11-30 20:01:07 UTC) #15
Message was sent while issue was closed. 
The desk_unicode skp has 5156 clipRRects so it would be the one to show
improvements.

Powered by Google App Engine
This is Rietveld 408576698