Change name of NativeTheme::instance() to make it clear it's web only.

Change name of NativeTheme::instance() to make it clear it's web only.
(e.g. for rendering blink controls)

Remove almost all uses of NativeTheme::instance() throughout Chrome. For
OSX it should be safe to just use NativeThemeMac::instance() in its place.
For Views, views need to use GetNativeTheme() (after being added to a Widget).

BUG=558029
Committed: https://crrev.com/66a425008f1da8e72274421285fd5bf8d8d78d6b
Cr-Commit-Position: refs/heads/master@{#361434}

[Evan Stade, 2015-11-19 03:05:32]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2015-11-19 03:05:46]

Description was changed from

==========
Change name of NativeTheme::instance() to make it clear it's web only.
(e.g. for rendering blink controls)

Remove almost all uses of NativeTheme::instance() throughout Chrome. For
OSX it should be safe to just use NativeThemeMac::instance() in its place.
For Views, views need to use GetNativeTheme() (after being added to a Widget).

BUG=558029
==========

to

==========
Change name of NativeTheme::instance() to make it clear it's web only.
(e.g. for rendering blink controls)

Remove almost all uses of NativeTheme::instance() throughout Chrome. For
OSX it should be safe to just use NativeThemeMac::instance() in its place.
For Views, views need to use GetNativeTheme() (after being added to a Widget).

BUG=558029
==========

[commit-bot: I haz the power, 2015-11-19 03:06:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461923002/20001

[Evan Stade, 2015-11-19 03:29:10]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-19 03:29:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461923002/40001

[commit-bot: I haz the power, 2015-11-19 04:00:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 04:00:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Evan Stade, 2015-11-19 23:29:14]

estade@chromium.org changed reviewers:
+ sadrul@chromium.org

[Evan Stade, 2015-11-19 23:29:14]

Sadrul, could you take a look at ui/ before I ask for OWNERS reviews from all
the other pieces this touches?

https://codereview.chromium.org/1461923002/diff/1/ui/views/button_drag_utils.cc
File ui/views/button_drag_utils.cc (left):

https://codereview.chromium.org/1461923002/diff/1/ui/views/button_drag_utils....
ui/views/button_drag_utils.cc:51: widget ? widget->GetNativeTheme() :
ui::NativeTheme::instance();
I looked at the call sites and I think |widget| is always non null. Exercising
the code (dragging from the location icon or url text) likewise worked fine.

https://codereview.chromium.org/1461923002/diff/1/ui/views/controls/scrollbar...
File ui/views/controls/scrollbar/native_scroll_bar_views.cc (left):

https://codereview.chromium.org/1461923002/diff/1/ui/views/controls/scrollbar...
ui/views/controls/scrollbar/native_scroll_bar_views.cc:380: theme =
ui::NativeTheme::instance();
likewise I think theme is always non-null here

[sadrul, 2015-11-20 18:06:09]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2015-11-20 18:06:09]

--> sky@ would be a better reviewer for this.

[Evan Stade, 2015-11-20 21:26:16]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-20 21:26:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461923002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461923002/80001

[commit-bot: I haz the power, 2015-11-20 22:04:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 22:04:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sky, 2015-11-20 22:09:04]

https://codereview.chromium.org/1461923002/diff/80001/ui/native_theme/native_...
File ui/native_theme/native_theme.h (right):

https://codereview.chromium.org/1461923002/diff/80001/ui/native_theme/native_...
ui/native_theme/native_theme.h:353: static NativeTheme* GetInstanceForWeb();
Is it possible to remove this function entirely? Can't the blink side, or
wherever, figure out the right one to call?

[Evan Stade, 2015-11-20 22:23:45]

https://codereview.chromium.org/1461923002/diff/80001/ui/native_theme/native_...
File ui/native_theme/native_theme.h (right):

https://codereview.chromium.org/1461923002/diff/80001/ui/native_theme/native_...
ui/native_theme/native_theme.h:353: static NativeTheme* GetInstanceForWeb();
On 2015/11/20 22:09:04, sky wrote:
> Is it possible to remove this function entirely? Can't the blink side, or
> wherever, figure out the right one to call?

I would like to do that, but it's referenced from both content/ and components/
so I don't know of a better place to put this.

[sky, 2015-11-22 16:01:48]

LGTM

[Evan Stade, 2015-11-23 19:27:58]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-23 19:29:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461923002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461923002/100001

[commit-bot: I haz the power, 2015-11-23 20:12:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 20:12:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Evan Stade, 2015-11-23 21:14:15]

estade@chromium.org changed reviewers:
+ avi@chromium.org

[Evan Stade, 2015-11-23 21:14:16]

+avi for content/

[Evan Stade, 2015-11-23 21:14:22]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-23 21:15:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461923002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461923002/120001

[Avi (use Gerrit), 2015-11-23 22:35:36]

lgtm

[Evan Stade, 2015-11-23 22:40:03]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2015-11-23 22:40:09]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-11-23 22:40:09]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1461923002/#ps120001
(title: "NATIVE_THEME_EXPORT for mac")

[commit-bot: I haz the power, 2015-11-23 22:41:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461923002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461923002/120001

[commit-bot: I haz the power, 2015-11-23 23:55:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 23:55:44]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-11-24 02:38:36]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-11-24 02:40:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461923002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461923002/120001

[commit-bot: I haz the power, 2015-11-24 04:14:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 04:14:53]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-11-24 20:07:57]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-11-24 20:08:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1461923002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1461923002/120001

[commit-bot: I haz the power, 2015-11-24 20:41:49]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-11-24 20:42:50]

Patchset 7 (id:??) landed as
https://crrev.com/66a425008f1da8e72274421285fd5bf8d8d78d6b
Cr-Commit-Position: refs/heads/master@{#361434}