Issue 14619040: Revert "GeneratorFunction() makes generator instances"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14619040: Revert "GeneratorFunction() makes generator instances" (Closed)

Created:
7 years, 7 months ago by wingo

Modified:
7 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "GeneratorFunction() makes generator instances" This reverts r14684 because of blink LayoutTest failures in inspector/debugger/debugger-pause-in-internal.html. R=mstarzinger@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=14694

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -53 lines)			Patch
M	src/generator.js	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	src/v8natives.js	View	2 chunks	+9 lines, -15 lines	0 comments	Download
M	test/mjsunit/harmony/generators-iteration.js	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	test/mjsunit/harmony/generators-runtime.js	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

wingo

This CL reverts a previous commit due to test failures. I had uploaded another reversion ...

7 years, 7 months ago (2013-05-15 15:35:47 UTC) #1

wingo

7 years, 7 months ago (2013-05-15 15:58:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14694 (presubmit successful).