Issue 14619028: Merge 198613 "Files.app: Fixed the icon of image open item in de..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14619028: Merge 198613 "Files.app: Fixed the icon of image open item in de..." (Closed)

Created:
7 years, 7 months ago by yoshiki

Modified:
7 years, 7 months ago

Reviewers:
hirono

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

More Reviews

Description

Merge 198613 "Files.app: Fixed the icon of image open item in de..." Marging on behalf of hirono@chromium.org. > Files.app: Fixed the icon of image open item in default action dialog > > Originally, if a task item has both 'iconType' and 'iconUrl' properties, > 'iconType' is used in the tasks menu and > 'iconUrl' is used in the default action dialog. > > This CL fixed the priority for default action dialog so that both > priorities are same. > > BUG=237153 > TEST=Open 'default action dialog' and check the icon. > > Review URL: https://chromiumcodereview.appspot.com/14589007 TBR=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199354

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/resources/file_manager/js/default_action_dialog.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r199354.

Expand Messages | Collapse Messages