Skip ABI verification for tests of __builtin_{frame,return}_address.

tests/toolchain/nacl.scons

 # -*- python -*-
 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 Import('env')
 
 # force inclusion of entire library, so that we can validate it
 # NOTE: This approach does not work for -lc because of tons of
 #       undefined symbols which would have to be stubbed out
@@ skipping 23 matching lines @@
                             EXTRA_LINKFLAGS=DEP_LINKFLAGS,
                             LIBS=DEP_LIBS,
                             _LIBFLAGS='')
 node = env.CommandValidatorTestNacl('whole_archive_test.out',
                                     image=nexe)
 env.AddNodeToTestSuite(node,
                        ['toolchain_tests', 'small_tests'],
                        'run_whole_archive_test')
 
 
-TESTS_TO_RUN = [
-     # (src, exit_status, golden_file, cond),
-     # The valus None for golden_file means no golden file, c.f.
-     #  SConstruct::CommandTest()
-     ('setlongjmp.c', '55', None, True),
-     ('intrinsics.cc', '55', None, True),
-     ('float2.c', '0', True, True),
-     ('frame_addresses.c', '0', None, True),
-     # NOTE: this test uses bitcode asm's
-     ('llvm_math_intrinsics.c', '0', True, env.Bit('bitcode')),
-     # NOTE: this test uses bitcode asm's
-     ('llvm_bitmanip_intrinsics.c', '0', True, env.Bit('bitcode')),
-     ('llvm_atomic_intrinsics.c', '55', None, True),
-]
+# Test various intrinsics.
+# Some of the intrinsic tests cover intrinsics that we do not want to
+# support. For example, llvm.frameaddress. If that is the case, we will
+# use the nonstable_env as our test_env in AddIntrinsicTest.
+if env.Bit('bitcode'):
+  nonstable_env = env.Clone()
+  nonstable_env.Append(LINKFLAGS=['--pnacl-disable-abi-check'])
+else:
+  nonstable_env = env
 
-for src, exit_status, golden_file, cond in TESTS_TO_RUN:
-  if not cond: continue
+
+def AddIntrinsicTest(test_env, src, exit_status, has_golden_file=False):
   name = src.split('.')[0]
-  if golden_file == True:
-    golden_file = env.File(name + '.stdout')
+  if has_golden_file:
+    golden_file = test_env.File(name + '.stdout')
+  else:
+    golden_file = None
 
-  nexe = env.ComponentProgram(name, src, EXTRA_LIBS=['${NONIRT_LIBS}'])
-  node = env.CommandSelLdrTestNacl(name + '.out',
-                                   nexe,
-                                   exit_status=exit_status,
-                                   stdout_golden=golden_file)
-  env.AddNodeToTestSuite(node,
-                         ['toolchain_tests','small_tests'],
-                         'run_' + name + '_test')
+  nexe = test_env.ComponentProgram(name, src, EXTRA_LIBS=['${NONIRT_LIBS}'])
+  node = test_env.CommandSelLdrTestNacl(name + '.out',
+                                        nexe,
+                                        exit_status=exit_status,
+                                        stdout_golden=golden_file)
+  test_env.AddNodeToTestSuite(node,
+                              ['toolchain_tests','small_tests'],
+                              'run_' + name + '_test')
+
+
+AddIntrinsicTest(env, 'setlongjmp.c', '55')
+AddIntrinsicTest(env, 'intrinsics.cc', '55'),
+AddIntrinsicTest(env, 'float2.c', '0', has_golden_file=True)
+# Consider llvm.frameaddress and llvm.returnaddress non-stable,
+# since we may want to hide return and stack addresses in the future.
+AddIntrinsicTest(nonstable_env, 'frame_addresses.c', '0'),
+AddIntrinsicTest(nonstable_env, 'return_address.c', '55')
+# TODO(jvoung): Revisit stability of llvm math, bitmanip, and atomic intrinsics.
+if env.Bit('bitcode'):
+  # These two tests redirect C function calls to llvm instrinsic functions,
+  # so they only work w/ PNaCl.
+  AddIntrinsicTest(nonstable_env, 'llvm_math_intrinsics.c', '0',
+                   has_golden_file=True)
+  AddIntrinsicTest(nonstable_env, 'llvm_bitmanip_intrinsics.c', '0',
+                   has_golden_file=True)
+AddIntrinsicTest(nonstable_env, 'llvm_atomic_intrinsics.c', '55')
 
 
 # initfini test
 initfini_obj = env.ComponentObject('initfini.c')
 
 def AddInitFiniTest(env, name, extra_libs):
   nexe = env.ComponentProgram(name,
                               [initfini_obj],
                               EXTRA_LIBS=extra_libs + ['${NONIRT_LIBS}'])
   golden_file = env.File(name + '.stdout')
@@ skipping 50 matching lines @@
 bias_env.AddNodeToTestSuite(node, ['toolchain_tests', 'small_tests'],
                             'run_pthread_cleanup_test')
 
 
 # NOTE: the tests below break easily under valgrid and since
 #       they do not exercise malloc/free we exclude
 if env.IsRunningUnderValgrind():
   Return()
 
 
-nexe = env.ComponentProgram('return_address', 'return_address.c',
-                            EXTRA_LIBS=['${NONIRT_LIBS}'])
-node = env.CommandSelLdrTestNacl('return_address.out',
-                                 nexe,
-                                 exit_status='55')
-env.AddNodeToTestSuite(node,
-                       ['toolchain_tests', 'small_tests'],
-                       'run_return_address_test')
-
 # NOTE: we assume that the incoming env contains '-O2', '-fomit-frame-pointer'
 def MakeEnv(use_opts, use_frames):
   new_env = env.Clone()
   # AddBiasForPNaCl() is only needed for stack_frame.cc and eh_return.c.
   if new_env.Bit('bitcode'):
     new_env.AddBiasForPNaCl()
   new_env.FilterOut(CFLAGS=['-pedantic'])
   new_env.FilterOut(CCFLAGS=['-pedantic'])
   if use_frames:
     new_env.FilterOut(CFLAGS=['-fomit-frame-pointer'])
@@ skipping 193 matching lines @@
     env.AddNodeToTestSuite(node,
                            ['toolchain_tests', 'small_tests'],
                            'run_' + name + '_test')
   AddAlignedCodeTest('aligned_code',
                      env.ComponentProgram('aligned_code', ['aligned_code.c'],
                                           EXTRA_LIBS=['${NONIRT_LIBS}']))
   if not env.Bit('nacl_disable_shared'):
     AddAlignedCodeTest('aligned_code_lib',
                        env.NaClSharedLibrary('aligned_code_lib',
                                              ['aligned_code_lib.c']))