Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 14619016: Add WebKit prefix to MediaSource,SourceBuffer, and SourceBufferList objects. (Closed)

Created:
7 years, 7 months ago by acolwell GONE FROM CHROMIUM
Modified:
7 years, 7 months ago
Reviewers:
jamesr, eseidel
CC:
blink-reviews, jamesr, Rik, eae+blinkwatch, abarth_chromum.org, danakj, feature-media-reviews_chromium.org, pdr., Stephen Chennney, jeez, vcarbune.chromium
Visibility:
Public.

Description

Add WebKit prefix to MediaSource,SourceBuffer, and SourceBufferList objects. The current MediaSource API implementation is prefixed from JavaScript's point of view, but is not in the C++ code. I plan to implement an unprefixed version of the MediaSource API that is consistent with the current spec. The prefixed version needs to be moved aside to make room for the unprefixed version which will be quite different because of significant changes to the spec over the last 6 months. These objects are also being migrated to a new runtime flag to make it possible to enable/disable the prefixed and unprefixed versions independently. BUG=239485 TEST=No new tests since this is just a class rename. R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150131

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase and remove empty line #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -1244 lines) Patch
M LayoutTests/http/tests/media/media-source/video-media-source-objects-expected.txt View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/public/WebRuntimeFeatures.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebMediaSourceImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/src/WebMediaSourceImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebRuntimeFeatures.cpp View 1 1 chunk +16 lines, -2 lines 0 comments Download
M Source/core/dom/EventTarget.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/EventTargetFactory.in View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/DOMURL.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/DOMURL.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/DOMURL.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 10 chunks +13 lines, -14 lines 0 comments Download
M Source/core/html/PublicURLManager.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/DOMWindow.idl View 1 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/MediaPlayer.h View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/platform/graphics/MediaPlayer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/graphics/MediaPlayerPrivate.h View 1 chunk +1 line, -1 line 0 comments Download
D Source/modules/mediasource/MediaSource.h View 1 chunk +0 lines, -100 lines 0 comments Download
D Source/modules/mediasource/MediaSource.cpp View 1 chunk +0 lines, -333 lines 0 comments Download
D Source/modules/mediasource/MediaSource.idl View 1 chunk +0 lines, -65 lines 0 comments Download
M Source/modules/mediasource/MediaSourceRegistry.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediasource/MediaSourceRegistry.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
D Source/modules/mediasource/SourceBuffer.h View 1 chunk +0 lines, -74 lines 0 comments Download
D Source/modules/mediasource/SourceBuffer.cpp View 1 chunk +0 lines, -177 lines 0 comments Download
D Source/modules/mediasource/SourceBuffer.idl View 1 chunk +0 lines, -48 lines 0 comments Download
D Source/modules/mediasource/SourceBufferList.h View 1 chunk +0 lines, -86 lines 0 comments Download
D Source/modules/mediasource/SourceBufferList.cpp View 1 chunk +0 lines, -115 lines 0 comments Download
D Source/modules/mediasource/SourceBufferList.idl View 1 chunk +0 lines, -49 lines 0 comments Download
A + Source/modules/mediasource/WebKitMediaSource.h View 3 chunks +17 lines, -17 lines 0 comments Download
A + Source/modules/mediasource/WebKitMediaSource.cpp View 12 chunks +32 lines, -32 lines 0 comments Download
A + Source/modules/mediasource/WebKitMediaSource.idl View 1 chunk +6 lines, -6 lines 0 comments Download
A + Source/modules/mediasource/WebKitSourceBuffer.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + Source/modules/mediasource/WebKitSourceBuffer.cpp View 8 chunks +26 lines, -27 lines 0 comments Download
A + Source/modules/mediasource/WebKitSourceBuffer.idl View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/modules/mediasource/WebKitSourceBufferList.h View 3 chunks +14 lines, -14 lines 0 comments Download
A + Source/modules/mediasource/WebKitSourceBufferList.cpp View 4 chunks +14 lines, -15 lines 0 comments Download
A + Source/modules/mediasource/WebKitSourceBufferList.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/modules.gypi View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
acolwell GONE FROM CHROMIUM
Intent to Implement for unprefixed MediaSource API will be coming shortly. This just moves the ...
7 years, 7 months ago (2013-05-09 17:17:42 UTC) #1
eseidel
lgtm This is going to get confusing fast. :) Just like how notifications vs. legacy ...
7 years, 7 months ago (2013-05-09 20:05:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/14619016/1
7 years, 7 months ago (2013-05-09 20:05:31 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_bare_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_bare_presubmit&number=734
7 years, 7 months ago (2013-05-09 20:09:45 UTC) #4
acolwell GONE FROM CHROMIUM
On 2013/05/09 20:05:22, Eric Seidel wrote: > lgtm > > This is going to get ...
7 years, 7 months ago (2013-05-09 20:23:41 UTC) #5
acolwell GONE FROM CHROMIUM
jamesr@ : Can I please have an OWNERS lgtm for Source/WebKit/chromium/public changes.
7 years, 7 months ago (2013-05-09 20:50:28 UTC) #6
jamesr
Eric's an OWNER for WebRuntimeFeatures.h
7 years, 7 months ago (2013-05-09 20:51:54 UTC) #7
acolwell GONE FROM CHROMIUM
On 2013/05/09 20:51:54, jamesr wrote: > Eric's an OWNER for WebRuntimeFeatures.h Hmm.. it looks like ...
7 years, 7 months ago (2013-05-09 20:59:39 UTC) #8
jamesr
That should work. Any idea why the presubmit doesn't like eseidel's review on this patch, ...
7 years, 7 months ago (2013-05-09 21:03:26 UTC) #9
Dirk Pranke
On 2013/05/09 21:03:26, jamesr wrote: > That should work. Any idea why the presubmit doesn't ...
7 years, 7 months ago (2013-05-09 21:08:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/14619016/13001
7 years, 7 months ago (2013-05-09 21:45:46 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_layout for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout&number=1596
7 years, 7 months ago (2013-05-10 03:49:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/14619016/13001
7 years, 7 months ago (2013-05-10 14:15:44 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=1798
7 years, 7 months ago (2013-05-10 20:31:13 UTC) #14
acolwell GONE FROM CHROMIUM
7 years, 7 months ago (2013-05-10 20:34:22 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 manually as r150131 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698