tools/dom/scripts/systemnative.py - Issue 14619013: Explicitly implementing some DOM iterable APIs for performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/systemnative.py

Issue 14619013: Explicitly implementing some DOM iterable APIs for performance (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/dom/scripts/systemhtml.py ('K') | « tools/dom/scripts/systemhtml.py ('k') | tools/dom/templates/immutable_list_mixin.darttemplate » ('j') | tools/dom/templates/immutable_list_mixin.darttemplate » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/scripts/systemnative.py

diff --git a/tools/dom/scripts/systemnative.py b/tools/dom/scripts/systemnative.py

index bbd9be37b82fc11bf06ef664c1e756ed1c4d9b07..51e578e22c6eb97c622249bb431715010fbda7e4 100644

--- a/tools/dom/scripts/systemnative.py

+++ b/tools/dom/scripts/systemnative.py

@@ -428,7 +428,11 @@ class DartiumBackend(HtmlDartGenerator):

else:

self._members_emitter.Emit(

'\n'

- ' $TYPE operator[](int index) native "$(INTERFACE)_item_Callback";\n',

+ ' $TYPE operator[](int index) {\n'

sra1 2013/05/09 19:55:50 Does the native code to a bounds check?

blois 2013/05/09 20:00:25 It appears to have the same behavior as JS.

+ ' if (index < 0 || index >= length) throw new RangeError.range(index, 0, length);\n'

sra1 2013/05/09 19:55:50 line length

blois 2013/05/09 22:49:24 Done.

+ ' return _nativeIndexedGetter(index);\n'

+ ' }\n'

+ ' $TYPE _nativeIndexedGetter(int index) native "$(INTERFACE)_item_Callback";\n',

TYPE=self.SecureOutputType(element_type),

INTERFACE=self._interface.id)