Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: sdk/lib/io/socket.dart

Issue 14619008: Add static getters for common internet addresses (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/io/socket.dart
diff --git a/sdk/lib/io/socket.dart b/sdk/lib/io/socket.dart
index 344b0a97c41ec4cc06bfbd680271938aac6b93ea..d507c974e3299a301ca2f7222842ad13ae8afb92 100644
--- a/sdk/lib/io/socket.dart
+++ b/sdk/lib/io/socket.dart
@@ -6,12 +6,12 @@ part of dart.io;
/**
- * [InternetAddressType] is the type an [InternetAddress]. Currently, IPv4 and
- * IPv6 are supported.
+ * [InternetAddressType] is the type an [InternetAddress]. Currently,
+ * IP version 4 and IP version 6 are supported.
Bill Hesse 2013/04/30 10:50:22 Maybe say (IPv4) and (IPv6) in parentheses? I hav
Søren Gjesse 2013/04/30 11:28:41 Done.
*/
class InternetAddressType {
- static const InternetAddressType IPv4 = const InternetAddressType._(0);
- static const InternetAddressType IPv6 = const InternetAddressType._(1);
+ static const InternetAddressType IP_V4 = const InternetAddressType._(0);
+ static const InternetAddressType IP_V6 = const InternetAddressType._(1);
static const InternetAddressType ANY = const InternetAddressType._(-1);
final int _value;
@@ -19,24 +19,24 @@ class InternetAddressType {
const InternetAddressType._(int this._value);
factory InternetAddressType._from(int value) {
- if (value == 0) return IPv4;
- if (value == 1) return IPv6;
+ if (value == 0) return IP_V4;
+ if (value == 1) return IP_V6;
throw new ArgumentError("Invalid type: $value");
}
/**
- * Get the name of the type, e.g. "IPv4" or "IPv6".
+ * Get the name of the type, e.g. "IP_V4" or "IP_V6".
*/
String get name {
switch (_value) {
case -1: return "ANY";
- case 0: return "IPv4";
- case 1: return "IPv6";
+ case 0: return "IP_V4";
+ case 1: return "IP_V6";
default: throw new ArgumentError("Invalid InternetAddress");
}
}
- String toString() => "InternetAddressType($name)";
+ String toString() => "InternetAddressType: $name";
}
@@ -47,7 +47,31 @@ class InternetAddressType {
*/
abstract class InternetAddress {
/**
- * The [type] of the [InternetAddress] specified what IP procotol.
+ * IP version 4 loopback address. Use this address when listening on
+ * or connecting to the loopback adapter using IP version 4.
+ */
+ external static InternetAddress get LOOPBACK_IP_V4;
+
+ /**
+ * IP version 6 loopback address. Use this address when listening on
+ * or connecting to the loopback adapter using IP version 6.
+ */
+ external static InternetAddress get LOOPBACK_IP_V6;
+
+ /**
+ * IP version 4 any address. Use this address when listening on
+ * all adapters IP addresses using IP version 4.
+ */
+ external static InternetAddress get ANY_IP_V4;
+
+ /**
+ * IP version 6 any address. Use this address when listening on
+ * all adapters IP addresses using IP version 6.
+ */
+ external static InternetAddress get ANY_IP_V6;
+
+ /**
+ * The [type] of the [InternetAddress] specified what IP protocol.
*/
InternetAddressType type;
@@ -62,13 +86,14 @@ abstract class InternetAddress {
String get host;
/**
- * Lookup a host, returning a Future of a list of [InternetAddress]s. If
- * [type] is [InternetAddressType.ANY], it will lookup both IPv4 and IPv6
- * addresses. The order of the list depends on the local machine and the DNS
- * lookup performed, and can as such change over time.
+ * Lookup a host, returning a Future of a list of
+ * [InternetAddress]s. If [type] is [InternetAddressType.ANY], it
+ * will lookup both IP version 4 and IP version 6 addresses. The
+ * order of the list depends on the local machine and the DNS lookup
+ * performed, and can as such change over time.
Bill Hesse 2013/04/30 10:50:22 I would remove "as such". If necessary, say "ther
Søren Gjesse 2013/04/30 11:28:41 Done.
*/
external static Future<List<InternetAddress>> lookup(
- String host, {InternetAddressType type: InternetAddressType.IPv4});
+ String host, {InternetAddressType type: InternetAddressType.IP_V4});
}
/**

Powered by Google App Engine
This is Rietveld 408576698