Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1461893002: Android Chromoting: Disable hamburger animation. (Closed)

Created:
5 years, 1 month ago by Lambros
Modified:
5 years ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android Chromoting: Disable hamburger animation. This is a little complex, for reasons that are explained in the code comments. Also, this refactors ChromotingUtil to make it easier to tint arbitrary Drawables. Committed: https://crrev.com/eaace2b1431b3b411dccc111098e3f49978b87a6 Cr-Commit-Position: refs/heads/master@{#361240}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't handle NotFoundException #

Messages

Total messages: 9 (3 generated)
Lambros
Not a high priority, but it addresses one of the comments from UX review.
5 years, 1 month ago (2015-11-19 01:54:20 UTC) #2
Sergey Ulanov
lgtm https://codereview.chromium.org/1461893002/diff/1/remoting/android/java/src/org/chromium/chromoting/ChromotingUtil.java File remoting/android/java/src/org/chromium/chromoting/ChromotingUtil.java (right): https://codereview.chromium.org/1461893002/diff/1/remoting/android/java/src/org/chromium/chromoting/ChromotingUtil.java#newcode32 remoting/android/java/src/org/chromium/chromoting/ChromotingUtil.java:32: // The resource compiler should prevent this from ...
5 years ago (2015-11-23 22:01:13 UTC) #3
Lambros
https://codereview.chromium.org/1461893002/diff/1/remoting/android/java/src/org/chromium/chromoting/ChromotingUtil.java File remoting/android/java/src/org/chromium/chromoting/ChromotingUtil.java (right): https://codereview.chromium.org/1461893002/diff/1/remoting/android/java/src/org/chromium/chromoting/ChromotingUtil.java#newcode32 remoting/android/java/src/org/chromium/chromoting/ChromotingUtil.java:32: // The resource compiler should prevent this from happening. ...
5 years ago (2015-11-23 23:48:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461893002/20001
5 years ago (2015-11-24 01:51:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-24 03:14:36 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-24 03:15:30 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eaace2b1431b3b411dccc111098e3f49978b87a6
Cr-Commit-Position: refs/heads/master@{#361240}

Powered by Google App Engine
This is Rietveld 408576698