src/objects-inl.h - Issue 146183006: Allow externalizing strings in old pointer space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 146183006: Allow externalizing strings in old pointer space. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Also fix two-byte String::MakeExternal Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index dd3c0b182d616fda37b0c66d24acba52e2593570..18926bfbb1d57e9e0449ea888be13e4992b7cdb4 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -3193,6 +3193,7 @@ void ExternalAsciiString::update_data_cache() {

void ExternalAsciiString::set_resource(

const ExternalAsciiString::Resource* resource) {

+ ASSERT(IsAligned(reinterpret_cast<intptr_t>(resource), kPointerSize));

*reinterpret_cast<const Resource**>(

FIELD_ADDR(this, kResourceOffset)) = resource;

if (resource != NULL) update_data_cache();

« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »