Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 146183002: Add missing chrome_version_header dependency to browser target (Closed)

Created:
6 years, 11 months ago by csharp
Modified:
6 years, 10 months ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add missing chrome_version_header dependency to browser target This is needed by chrome_elf_init_win.cc BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248527

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Removing space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
csharp
6 years, 11 months ago (2014-01-23 22:34:36 UTC) #1
Cait (Slow)
https://codereview.chromium.org/146183002/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/146183002/diff/1/chrome/chrome_browser.gypi#newcode2621 chrome/chrome_browser.gypi:2621: '../chrome/chrome.gyp:chrome_version_header', Do we need this all the time, or ...
6 years, 11 months ago (2014-01-27 15:31:18 UTC) #2
csharp
https://codereview.chromium.org/146183002/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/146183002/diff/1/chrome/chrome_browser.gypi#newcode2621 chrome/chrome_browser.gypi:2621: '../chrome/chrome.gyp:chrome_version_header', On 2014/01/27 15:31:19, Cait Phillips wrote: > Do ...
6 years, 10 months ago (2014-02-03 15:10:12 UTC) #3
Cait (Slow)
LGTM % whitespace nit https://codereview.chromium.org/146183002/diff/90002/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/146183002/diff/90002/chrome/chrome_browser.gypi#newcode3411 chrome/chrome_browser.gypi:3411: '../chrome/chrome.gyp:chrome_version_header', nit: remove trailing whitespace ...
6 years, 10 months ago (2014-02-03 15:12:37 UTC) #4
csharp
https://codereview.chromium.org/146183002/diff/90002/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/146183002/diff/90002/chrome/chrome_browser.gypi#newcode3411 chrome/chrome_browser.gypi:3411: '../chrome/chrome.gyp:chrome_version_header', On 2014/02/03 15:12:37, Cait Phillips wrote: > nit: ...
6 years, 10 months ago (2014-02-03 16:32:12 UTC) #5
csharp
The CQ bit was checked by csharp@chromium.org
6 years, 10 months ago (2014-02-03 16:32:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/146183002/160001
6 years, 10 months ago (2014-02-03 16:32:42 UTC) #7
commit-bot: I haz the power
Change committed as 248527
6 years, 10 months ago (2014-02-03 18:22:49 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 18:22:52 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 18:22:57 UTC) #10
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698