Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1461823003: [simdjs] Implement type check and error raising in SIMD runtime functions. (Closed)

Created:
5 years, 1 month ago by gdeepti1
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement type check and error raising semantics in SIMD runtime functions. - Throw type errors instead of runtime asserts. - Also required for SIMD tests ported to Test262 to work with V8 BUG=4501 LOG=N Committed: https://crrev.com/21a7a1069f0e5aa702b8a416732176c005284761 Cr-Commit-Position: refs/heads/master@{#32187}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Macro name change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -24 lines) Patch
M src/messages.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-simd.cc View 1 2 3 18 chunks +33 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
gdeepti1
5 years, 1 month ago (2015-11-19 21:37:54 UTC) #3
Dan Ehrenberg
https://codereview.chromium.org/1461823003/diff/40001/src/runtime/runtime-simd.cc File src/runtime/runtime-simd.cc (right): https://codereview.chromium.org/1461823003/diff/40001/src/runtime/runtime-simd.cc#newcode215 src/runtime/runtime-simd.cc:215: #define CONVERT_ARG_HANDLE_THROW(Type, name, index) \ This throws a SIMD-specific ...
5 years, 1 month ago (2015-11-19 22:10:59 UTC) #5
gdeepti1
https://codereview.chromium.org/1461823003/diff/40001/src/runtime/runtime-simd.cc File src/runtime/runtime-simd.cc (right): https://codereview.chromium.org/1461823003/diff/40001/src/runtime/runtime-simd.cc#newcode215 src/runtime/runtime-simd.cc:215: #define CONVERT_ARG_HANDLE_THROW(Type, name, index) \ On 2015/11/19 22:10:59, Dan ...
5 years, 1 month ago (2015-11-20 19:15:23 UTC) #7
Dan Ehrenberg
lgtm
5 years, 1 month ago (2015-11-23 19:55:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461823003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461823003/60001
5 years, 1 month ago (2015-11-23 20:32:01 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-23 21:24:55 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 21:25:17 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/21a7a1069f0e5aa702b8a416732176c005284761
Cr-Commit-Position: refs/heads/master@{#32187}

Powered by Google App Engine
This is Rietveld 408576698