Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1461823002: Handle device ONC AllowOnlyPolicyNetworksToConnect (Closed)

Created:
5 years, 1 month ago by fqj
Modified:
5 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, cschuet (SLOW)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle device ONC AllowOnlyPolicyNetworksToConnect BUG=208378 Committed: https://crrev.com/44cc1ab351e14882f3e0522004eddca120a780e5 Cr-Commit-Position: refs/heads/master@{#360474}

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -1 line) Patch
M chromeos/network/auto_connect_handler.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chromeos/network/auto_connect_handler_unittest.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M chromeos/network/network_connection_handler.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chromeos/network/network_connection_handler.cc View 1 4 chunks +33 lines, -0 lines 0 comments Download
M chromeos/network/network_connection_handler_unittest.cc View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
fqj
PTAL.
5 years, 1 month ago (2015-11-18 23:35:48 UTC) #2
stevenjb
https://codereview.chromium.org/1461823002/diff/1/chromeos/network/network_connection_handler.cc File chromeos/network/network_connection_handler.cc (right): https://codereview.chromium.org/1461823002/diff/1/chromeos/network/network_connection_handler.cc#newcode544 chromeos/network/network_connection_handler.cc:544: managed_configuration_handler_->GetGlobalConfigFromPolicy(std::string()); Add comment for empty arg: std::string() /* no ...
5 years, 1 month ago (2015-11-18 23:46:47 UTC) #3
fqj
PTAL. https://codereview.chromium.org/1461823002/diff/1/chromeos/network/network_connection_handler.cc File chromeos/network/network_connection_handler.cc (right): https://codereview.chromium.org/1461823002/diff/1/chromeos/network/network_connection_handler.cc#newcode544 chromeos/network/network_connection_handler.cc:544: managed_configuration_handler_->GetGlobalConfigFromPolicy(std::string()); On 2015/11/18 23:46:47, stevenjb wrote: > Add ...
5 years, 1 month ago (2015-11-18 23:55:48 UTC) #4
stevenjb
lgtm
5 years, 1 month ago (2015-11-18 23:58:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461823002/20001
5 years, 1 month ago (2015-11-19 00:24:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 01:51:52 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 01:53:13 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/44cc1ab351e14882f3e0522004eddca120a780e5
Cr-Commit-Position: refs/heads/master@{#360474}

Powered by Google App Engine
This is Rietveld 408576698