Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1461813002: Call base::DispatchToMethod by the fully qualified name (Closed)

Created:
5 years, 1 month ago by tzik
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call base::DispatchToMethod by the fully qualified name DispatchToMethod in IPC is looked up in ADL rule for base::Tuple. That is going to unavailable when we start using std::tuple. This CL removes the ADL application to avoid the lookup error in advance. BUG=554987 Committed: https://crrev.com/1cec15c4d32cc538687e7e908f277e04005674ed Cr-Commit-Position: refs/heads/master@{#360687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ipc/ipc_message_macros.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461813002/1
5 years, 1 month ago (2015-11-18 23:28:57 UTC) #2
tzik
PTAL
5 years, 1 month ago (2015-11-18 23:52:11 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 01:51:18 UTC) #6
tzik
Updating reviewer from jeremy to tsepez. PTAL.
5 years, 1 month ago (2015-11-19 11:09:59 UTC) #8
Tom Sepez
lgtm
5 years, 1 month ago (2015-11-19 16:49:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461813002/1
5 years, 1 month ago (2015-11-19 22:56:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 23:31:29 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 23:32:22 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cec15c4d32cc538687e7e908f277e04005674ed
Cr-Commit-Position: refs/heads/master@{#360687}

Powered by Google App Engine
This is Rietveld 408576698