Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

Issue 1461783003: [DevTools] Get rid of floats in treeoutline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaseline Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) IBM Corp. 2009 All rights reserved. 2 * Copyright (C) IBM Corp. 2009 All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 } else { 349 } else {
350 this._valueElement = WebInspector.ObjectPropertiesSection.createValu eElementWithCustomSupport(result, wasThrown, titleElement); 350 this._valueElement = WebInspector.ObjectPropertiesSection.createValu eElementWithCustomSupport(result, wasThrown, titleElement);
351 } 351 }
352 var separatorElement = createElementWithClass("span", "watch-expressions -separator"); 352 var separatorElement = createElementWithClass("span", "watch-expressions -separator");
353 separatorElement.textContent = ": "; 353 separatorElement.textContent = ": ";
354 titleElement.appendChildren(this._nameElement, separatorElement, this._v alueElement); 354 titleElement.appendChildren(this._nameElement, separatorElement, this._v alueElement);
355 355
356 this._element.removeChildren(); 356 this._element.removeChildren();
357 this._objectPropertiesSection = null; 357 this._objectPropertiesSection = null;
358 if (!wasThrown && result && result.hasChildren && !result.customPreview( )) { 358 if (!wasThrown && result && result.hasChildren && !result.customPreview( )) {
359 headerElement.classList.add("watch-expression-object-header");
359 this._objectPropertiesSection = new WebInspector.ObjectPropertiesSec tion(result, headerElement); 360 this._objectPropertiesSection = new WebInspector.ObjectPropertiesSec tion(result, headerElement);
360 this._objectPresentationElement = this._objectPropertiesSection.elem ent; 361 this._objectPresentationElement = this._objectPropertiesSection.elem ent;
361 var objectTreeElement = this._objectPropertiesSection.objectTreeElem ent(); 362 var objectTreeElement = this._objectPropertiesSection.objectTreeElem ent();
362 objectTreeElement.toggleOnClick = false; 363 objectTreeElement.toggleOnClick = false;
363 objectTreeElement.listItemElement.addEventListener("click", this._on SectionClick.bind(this), false); 364 objectTreeElement.listItemElement.addEventListener("click", this._on SectionClick.bind(this), false);
364 objectTreeElement.listItemElement.addEventListener("dblclick", this. _dblClickOnWatchExpression.bind(this)); 365 objectTreeElement.listItemElement.addEventListener("dblclick", this. _dblClickOnWatchExpression.bind(this));
365 } else { 366 } else {
366 this._objectPresentationElement = headerElement; 367 this._objectPresentationElement = headerElement;
367 this._objectPresentationElement.addEventListener("dblclick", this._d blClickOnWatchExpression.bind(this)); 368 this._objectPresentationElement.addEventListener("dblclick", this._d blClickOnWatchExpression.bind(this));
368 } 369 }
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 contextMenu.appendApplicableItems(this._result); 425 contextMenu.appendApplicableItems(this._result);
425 }, 426 },
426 427
427 _copyValueButtonClicked: function() 428 _copyValueButtonClicked: function()
428 { 429 {
429 InspectorFrontendHost.copyText(this._valueElement.textContent); 430 InspectorFrontendHost.copyText(this._valueElement.textContent);
430 }, 431 },
431 432
432 __proto__: WebInspector.Object.prototype 433 __proto__: WebInspector.Object.prototype
433 } 434 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698