Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

Issue 1461783003: [DevTools] Get rid of floats in treeoutline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaseline Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 break; 118 break;
119 case DebuggerAgent.ScopeType.Global: 119 case DebuggerAgent.ScopeType.Global:
120 title = WebInspector.UIString("Global"); 120 title = WebInspector.UIString("Global");
121 break; 121 break;
122 } 122 }
123 123
124 var subtitle = scope.description(); 124 var subtitle = scope.description();
125 if (!title || title === subtitle) 125 if (!title || title === subtitle)
126 subtitle = undefined; 126 subtitle = undefined;
127 127
128 var titleElement = createElementWithClass("div"); 128 var titleElement = createElementWithClass("div", "scope-chain-sideba r-pane-section-header");
129 titleElement.createChild("div", "scope-chain-sidebar-pane-section-su btitle").textContent = subtitle; 129 titleElement.createChild("div", "scope-chain-sidebar-pane-section-su btitle").textContent = subtitle;
130 titleElement.createChild("div", "scope-chain-sidebar-pane-section-ti tle").textContent = title; 130 titleElement.createChild("div", "scope-chain-sidebar-pane-section-ti tle").textContent = title;
131 131
132 var section = new WebInspector.ObjectPropertiesSection(scope.object( ), titleElement, emptyPlaceholder, true, extraProperties); 132 var section = new WebInspector.ObjectPropertiesSection(scope.object( ), titleElement, emptyPlaceholder, true, extraProperties);
133 section[WebInspector.ScopeChainSidebarPane._pathSymbol] = title + ": " + (subtitle ? subtitle + ":" : ""); 133 section[WebInspector.ScopeChainSidebarPane._pathSymbol] = title + ": " + (subtitle ? subtitle + ":" : "");
134 section.addEventListener(TreeOutline.Events.ElementAttached, this._e lementAttached, this); 134 section.addEventListener(TreeOutline.Events.ElementAttached, this._e lementAttached, this);
135 section.addEventListener(TreeOutline.Events.ElementExpanded, this._e lementExpanded, this); 135 section.addEventListener(TreeOutline.Events.ElementExpanded, this._e lementExpanded, this);
136 section.addEventListener(TreeOutline.Events.ElementCollapsed, this._ elementCollapsed, this); 136 section.addEventListener(TreeOutline.Events.ElementCollapsed, this._ elementCollapsed, this);
137 137
138 if (scope.type() === DebuggerAgent.ScopeType.Global) 138 if (scope.type() === DebuggerAgent.ScopeType.Global)
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 * @param {!WebInspector.ObjectPropertyTreeElement} treeElement 178 * @param {!WebInspector.ObjectPropertyTreeElement} treeElement
179 * @return {string} 179 * @return {string}
180 */ 180 */
181 _propertyPath: function(treeElement) 181 _propertyPath: function(treeElement)
182 { 182 {
183 return treeElement.treeOutline[WebInspector.ScopeChainSidebarPane._pathS ymbol] + WebInspector.ObjectPropertyTreeElement.prototype.propertyPath.call(tree Element); 183 return treeElement.treeOutline[WebInspector.ScopeChainSidebarPane._pathS ymbol] + WebInspector.ObjectPropertyTreeElement.prototype.propertyPath.call(tree Element);
184 }, 184 },
185 185
186 __proto__: WebInspector.SidebarPane.prototype 186 __proto__: WebInspector.SidebarPane.prototype
187 } 187 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698