Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1461783003: [DevTools] Get rid of floats in treeoutline. (Closed)

Created:
5 years, 1 month ago by dgozman
Modified:
5 years, 1 month ago
Reviewers:
sergeyv, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, plundblad+watch_chromium.org, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, je_julie, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-style_chromium.org, sergeyv+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman, dmazzoni, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Get rid of floats in treeoutline. This fixes a bunch of positioning and cropped selection bugs. BUG=548087 Committed: https://crrev.com/ce4b82a4e9159df2a166370c019b5e0211aca3eb Cr-Commit-Position: refs/heads/master@{#361216}

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -47 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/accessibilityNode.css View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/eventListenersView.css View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/objectPropertiesSection.css View 2 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/computedStyleSidebarPane.css View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspectorStyle.css View 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/requestHeadersView.css View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/resourcesPanel.css View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/security/sidebar.css View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/navigatorView.css View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css View 3 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/treeoutline.css View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
dgozman
Take a look please.
5 years, 1 month ago (2015-11-19 21:28:29 UTC) #2
pfeldman
lgtm
5 years, 1 month ago (2015-11-20 23:12:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461783003/1
5 years, 1 month ago (2015-11-20 23:16:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/138354)
5 years, 1 month ago (2015-11-21 01:07:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461783003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461783003/20001
5 years, 1 month ago (2015-11-23 20:42:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133066)
5 years, 1 month ago (2015-11-23 22:26:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461783003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461783003/20001
5 years, 1 month ago (2015-11-23 22:29:14 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 23:25:11 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 23:26:09 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ce4b82a4e9159df2a166370c019b5e0211aca3eb
Cr-Commit-Position: refs/heads/master@{#361216}

Powered by Google App Engine
This is Rietveld 408576698