third_party/WebKit/LayoutTests/fast/text/whitespace-created-when-siblings-added-back-to-front.html - Issue 1461773002: Ensure text nodes get an object if we're unsure that they will be collapsed

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/text/whitespace-created-when-siblings-added-back-to-front.html

Issue 1461773002: Ensure text nodes get an object if we're unsure that they will be collapsed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/repaint/text-in-relative-positioned-inline-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/text/whitespace-created-when-siblings-added-back-to-front-expected.html » ('j') | third_party/WebKit/Source/core/dom/Text.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 .f {

	4 float: left;

	5 }

	6 </style>

	7 <p id="p"></p>

	8 <script>

	9 window.onload = function (e) {

	10 var p = document.getElementById('p');

	11 p.innerHTML = 't<span class="f">e</span> <span class="f">x</span>t';

	12 };

	13 </script>

	14 <p>crbug.com/556733: Ensure whitespace gets created when we attached siblings fr om back to front. There should be a space between the t and the t.</p>
	esprehn 2015/12/03 07:03:32 If we ever reversed the order again this test woul If we ever reversed the order again this test wouldn't work right? Do we need to manually appendChild to make this test robust? rhogan 2015/12/03 19:45:32 Sure. Show quoted text On 2015/12/03 at 07:03:32, esprehn wrote: > If we ever reversed the order again this test wouldn't work right? Do we need to manually appendChild to make this test robust? Sure.
	15

OLD	NEW