Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: chrome/browser/push_messaging/push_messaging_notification_manager.cc

Issue 1461763003: Delete todo about auto-dismissing default notification after real one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/push_messaging/push_messaging_notification_manager.cc
diff --git a/chrome/browser/push_messaging/push_messaging_notification_manager.cc b/chrome/browser/push_messaging/push_messaging_notification_manager.cc
index c26f0b65f9a1136ad783f3d92c69a95ae27a7d58..86012872f2087849b0ec6342173292cdb1cecaaf 100644
--- a/chrome/browser/push_messaging/push_messaging_notification_manager.cc
+++ b/chrome/browser/push_messaging/push_messaging_notification_manager.cc
@@ -153,7 +153,7 @@ void PushMessagingNotificationManager::DidGetNotificationsFromDatabase(
}
#endif
- // If more than two notifications are showing for this Service Worker, close
+ // If more than one notification is showing for this Service Worker, close
// the default notification if it happens to be part of this group.
if (notification_count >= 2) {
for (const auto& notification_database_data : data) {
@@ -258,9 +258,6 @@ void PushMessagingNotificationManager::DidGetNotificationsShownAndNeeded(
// The site failed to show a notification when one was needed, and they have
// already failed once in the previous 10 push messages, so we will show a
// generic notification. See https://crbug.com/437277.
- //
- // TODO(johnme): The generic notification should probably automatically close
- // itself when the next push message arrives?
content::PlatformNotificationData notification_data;
notification_data.title =
url_formatter::FormatUrlForSecurityDisplayOmitScheme(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698