Issue 1461763003: Delete todo about auto-dismissing default notification after real one.

Issue 1461763003: Delete todo about auto-dismissing default notification after real one. (Closed)

Created:
5 years, 1 month ago by Michael van Ouwerkerk

Modified:
5 years, 1 month ago

Reviewers:
Peter Beverloo

CC:
chromium-reviews, Peter Beverloo, mvanouwerkerk+watch_chromium.org, johnme+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Delete todo about auto-dismissing default notification after real one. It was done in https://codereview.chromium.org/1149243005/ Committed: https://crrev.com/3096e94e154b261529ab684badee5a00a4197abe Cr-Commit-Position: refs/heads/master@{#360594}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	chrome/browser/push_messaging/push_messaging_notification_manager.cc	View		2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461763003/1

5 years, 1 month ago (2015-11-19 15:29:56 UTC) #5

commit-bot: I haz the power

5 years, 1 month ago (2015-11-19 16:06:19 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3096e94e154b261529ab684badee5a00a4197abe
Cr-Commit-Position: refs/heads/master@{#360594}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages