Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1461763002: Generalize API, fix bug, sort (Closed)

Created:
5 years, 1 month ago by Brian Wilkerson
Modified:
5 years, 1 month ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -99 lines) Patch
M pkg/analysis_server/test/stress/utilities/git.dart View 6 chunks +102 lines, -99 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
This addresses two of your review comments. It also, unfortunately, contains a bit of noise ...
5 years, 1 month ago (2015-11-18 21:58:34 UTC) #2
Paul Berry
lgtm
5 years, 1 month ago (2015-11-18 22:06:34 UTC) #3
Brian Wilkerson
5 years, 1 month ago (2015-11-18 22:07:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bc0f99c95ad6aeeccc1070c6204b62496fde40a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698