Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1461743004: [PartitionAlloc] Fix type names in fast malloc macro (Closed)

Created:
5 years, 1 month ago by Ruud van Asseldonk
Modified:
5 years, 1 month ago
Reviewers:
haraken
CC:
chromium-reviews, tyoshino+watch_chromium.org, pdr+renderingwatchlist_chromium.org, gavinp+prerender_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, blink-reviews-html_chromium.org, eae+blinkwatch, leviw+renderwatch, loading-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, blink-reviews, kinuko+watch, Nate Chapin, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[PartitionAlloc] Fix type names in fast malloc macro The type name in the |USING_FAST_MALLOC| macro is currently not used, which allowed a few typos to sneak in. This fixes those to prevent compile errors in case the type name is used in the future. Committed: https://crrev.com/ddc763cdec5788f27da528d35ab31a3428a1fc84 Cr-Commit-Position: refs/heads/master@{#360569}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/events/EventFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/PrerenderHandle.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Ruud van Asseldonk
haraken, can you please take a look at this four-line change?
5 years, 1 month ago (2015-11-19 12:03:13 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-19 12:05:11 UTC) #3
haraken
LGTM
5 years, 1 month ago (2015-11-19 12:05:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1461743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1461743004/1
5 years, 1 month ago (2015-11-19 12:08:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 13:05:17 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 13:05:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddc763cdec5788f27da528d35ab31a3428a1fc84
Cr-Commit-Position: refs/heads/master@{#360569}

Powered by Google App Engine
This is Rietveld 408576698